[GitHub] [iceberg] rdblue commented on a change in pull request #1586: Flink: support specifying user-provided hive-site.xml for hive catalog.

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #1586:
URL: https://github.com/apache/iceberg/pull/1586#discussion_r509453461



##########
File path: flink/src/test/java/org/apache/iceberg/flink/FlinkTestBase.java
##########
@@ -34,23 +40,53 @@
   private static TestHiveMetastore metastore = null;
   protected static HiveConf hiveConf = null;
   protected static HiveCatalog catalog = null;
-  protected static ConcurrentMap<String, Catalog> flinkCatalogs;
+
+  private volatile TableEnvironment tEnv = null;
 
   @BeforeClass
   public static void startMetastore() {
     FlinkTestBase.metastore = new TestHiveMetastore();
-    metastore.start();
+    metastore.start(15);

Review comment:
       Why did this change? Needing to increase the number of threads used by the Hive MetaStore is a red flag that this may be leaking Hive connections. In cases where all of the connections are handled by a `ClientPool`, we should not need to increase the number of handler threads. This helps us avoid leaks because we catch them in testing rather than at runtime.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org