You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2021/12/06 17:05:05 UTC
[GitHub] [brooklyn-server] zan-mateusz opened a new pull request #1283: Calling unmanage on a removed child that causes the corresponding dyn…
zan-mateusz opened a new pull request #1283:
URL: https://github.com/apache/brooklyn-server/pull/1283
…amicgroup item to be removed
As above. When removing children that have corresponding items in a group (e.g. DynamicGroup), the corresponding item in the group was not removed. Calling the unmanage() method when removing the child causes necessary event to be triggered, essentially removing the item from the group as required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-server] ahgittin commented on pull request #1283: Calling unmanage on a removed child that causes the corresponding dyn…
Posted by GitBox <gi...@apache.org>.
ahgittin commented on pull request #1283:
URL: https://github.com/apache/brooklyn-server/pull/1283#issuecomment-987768500
Don't think this is right -- caller code should unmanage the child, not ask the parent to remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-server] zan-mateusz closed pull request #1283: Calling unmanage on a removed child that causes the corresponding dyn…
Posted by GitBox <gi...@apache.org>.
zan-mateusz closed pull request #1283:
URL: https://github.com/apache/brooklyn-server/pull/1283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-server] iuliana commented on pull request #1283: Calling unmanage on a removed child that causes the corresponding dyn…
Posted by GitBox <gi...@apache.org>.
iuliana commented on pull request #1283:
URL: https://github.com/apache/brooklyn-server/pull/1283#issuecomment-987119969
But also, check if this build failure is caused by this change. I won't merge otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-server] zan-mateusz commented on pull request #1283: Calling unmanage on a removed child that causes the corresponding dyn…
Posted by GitBox <gi...@apache.org>.
zan-mateusz commented on pull request #1283:
URL: https://github.com/apache/brooklyn-server/pull/1283#issuecomment-987772543
The test failures are indeed caused by this change. As per discussions this can be achieved in another way without having to modify brooklyn server code, so that is what I will proceed with. Closing this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org