You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2017/08/15 07:00:36 UTC
Review Request 61642: Introduced a Framework::idle function in the
agent.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61642/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar and Vinod Kone.
Repository: mesos
Description
-------
This ensures the call-sites consistently check idleness of the
framework, it also aids readability in that it clarifies that
we remove idle frameworks.
Diffs
-----
src/slave/slave.hpp 1fe93dab1b2bef24721cc1bcffebe1b259e96d79
src/slave/slave.cpp 7381530515f86faf4c3e8f82bcd9483f6cf0498b
Diff: https://reviews.apache.org/r/61642/diff/1/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 61642: Introduced a Framework::idle function in
the agent.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61642/#review183547
-----------------------------------------------------------
src/slave/slave.hpp
Lines 857 (patched)
<https://reviews.apache.org/r/61642/#comment259553>
Can you add a TODO here to ensure a framework is not considered idle until terminal updates for pending tasks are not acked?
- Vinod Kone
On Aug. 22, 2017, 7:46 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61642/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2017, 7:46 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This ensures the call-sites consistently check idleness of the
> framework, it also aids readability in that it clarifies that
> we remove idle frameworks.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 0e07a1af733003bb897cbebb7c1f64437063353d
> src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a
>
>
> Diff: https://reviews.apache.org/r/61642/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 61642: Introduced a Framework::idle function in
the agent.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61642/
-----------------------------------------------------------
(Updated Aug. 22, 2017, 7:46 p.m.)
Review request for mesos, Anand Mazumdar and Vinod Kone.
Changes
-------
Rebased and clarified that idle includes no unacknowledged status updates.
Repository: mesos
Description
-------
This ensures the call-sites consistently check idleness of the
framework, it also aids readability in that it clarifies that
we remove idle frameworks.
Diffs (updated)
-----
src/slave/slave.hpp 0e07a1af733003bb897cbebb7c1f64437063353d
src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a
Diff: https://reviews.apache.org/r/61642/diff/2/
Changes: https://reviews.apache.org/r/61642/diff/1-2/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 61642: Introduced a Framework::idle function in
the agent.
Posted by Benjamin Mahler <bm...@apache.org>.
> On Aug. 22, 2017, 5:35 p.m., Vinod Kone wrote:
> > src/slave/slave.hpp
> > Lines 854 (patched)
> > <https://reviews.apache.org/r/61642/diff/1/?file=1797220#file1797220line854>
> >
> > I think "active" here might be misleading; we don't remove the framework if tasks/executors have been terminated but acks have not been received.
> >
> > How about:
> >
> > // Returns whether the framework all the frameworks's tasks and executors have completed,
> > // i.e., terminated and in case of tasks, also received acknowledgements for all pending updates.
> >
> > Still debating whether "idle" is a better word than "empty"
Updated the description:
```
// Returns whether the framework is idle, where idle is
// defined as having no activity:
// (1) The framework has no non-terminal tasks and executors.
// (2) All status updates have been acknowledged.
bool idle() const;
```
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61642/#review183492
-----------------------------------------------------------
On Aug. 15, 2017, 7 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61642/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2017, 7 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This ensures the call-sites consistently check idleness of the
> framework, it also aids readability in that it clarifies that
> we remove idle frameworks.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 0e07a1af733003bb897cbebb7c1f64437063353d
> src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a
>
>
> Diff: https://reviews.apache.org/r/61642/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 61642: Introduced a Framework::idle function in
the agent.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61642/#review183492
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/slave.hpp
Lines 854 (patched)
<https://reviews.apache.org/r/61642/#comment259509>
I think "active" here might be misleading; we don't remove the framework if tasks/executors have been terminated but acks have not been received.
How about:
// Returns whether the framework all the frameworks's tasks and executors have completed,
// i.e., terminated and in case of tasks, also received acknowledgements for all pending updates.
Still debating whether "idle" is a better word than "empty"
- Vinod Kone
On Aug. 15, 2017, 7 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61642/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2017, 7 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This ensures the call-sites consistently check idleness of the
> framework, it also aids readability in that it clarifies that
> we remove idle frameworks.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 1fe93dab1b2bef24721cc1bcffebe1b259e96d79
> src/slave/slave.cpp 7381530515f86faf4c3e8f82bcd9483f6cf0498b
>
>
> Diff: https://reviews.apache.org/r/61642/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>