[GitHub] [tvm] Wheest edited a comment on pull request #7142: Asymmetric padding in conv2d workload

[GitBox <gi...@apache.org>]

Wheest edited a comment on pull request #7142:
URL: https://github.com/apache/tvm/pull/7142#issuecomment-750293513


   Thanks for the tip! I've added a test for `conv2d_nchw_int8`, with a structure much like you suggested.  It fails in `main`, but is fixed in this PR.  Through the test, I identified a silly mistake I had made in the workload definition in the original commit, now fixed.
   
   Does the style of this test meet the standards you expect?  E.g. is the test being called as a nested function of `verify_conv2d_nchw_int8` the right place for this?
   
   If so, I will add a similar test for all of the ops touched by this PR.  Otherwise, happy to take some suggestions on how to improve this test before I reproduce it elsewhere.
   
   *EDIT* 
   CI still failed, I should have run *all* tests locally, rather than just the one I added.  I have discovered that dilation is also not used in the workload, so this PR will also add dilation to avoid this issue.  Will push the fix when available, earlier question about the test standard remains.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org