[lucy-issues] [jira] [Commented] (LUCY-214) Port terminfo tests to C

["Marvin Humphrey (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCY-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233980#comment-13233980 ] 

Marvin Humphrey commented on LUCY-214:
--------------------------------------

Commit r1303225 looks great in general!

There's one thing that should be updated -- we should use method calls rather
than accessing functions directly.  From Lucy::Docs::DevGuide:

{noformat}
For more information see the Clownfish docs, but if there's one thing you
should know about Clownfish OO before you start hacking, it's that method
calls are differentiated from functions by capitalization:

    Indexer_Add_Doc   <-- Method, typically uses dynamic dispatch.
    Indexer_add_doc   <-- Function, always a direct invocation.
{noformat}

You're not the first person who's gotten bitten by this.  Perhaps we can find
a way to make those functions static so that it's only possible to access
them as intended via vtable dynamic dispatch.

                
> Port terminfo tests to C
> ------------------------
>
>                 Key: LUCY-214
>                 URL: https://issues.apache.org/jira/browse/LUCY-214
>             Project: Lucy
>          Issue Type: Sub-task
>            Reporter: Logan Bell
>            Assignee: Logan Bell
>            Priority: Minor
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira