[jira] [Commented] (HTRACE-123) fix graphviz functionality in the htrace command

["Colin Patrick McCabe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HTRACE-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14340915#comment-14340915 ] 

Colin Patrick McCabe commented on HTRACE-123:
---------------------------------------------

cmd.go: move loadFile and loadJson to be next to one another.  The "graph" command now takes input as an argument rather than a flag.  {{./build/htrace /tmp/my-span-file}} feels more natural than {{./build/htrace \-\-input /tmp/my-span-file}}

graph.go: add newline at the end of graphviz output, on the line with the close brace.  Also, the {{io.Writer}} must be flushed before we close the file, or else the buffered data will be lost.

> fix graphviz functionality in the htrace command
> ------------------------------------------------
>
>                 Key: HTRACE-123
>                 URL: https://issues.apache.org/jira/browse/HTRACE-123
>             Project: HTrace
>          Issue Type: Bug
>    Affects Versions: 3.2.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HTRACE-123.001.patch
>
>
> Fix graphviz functionality in the htrace command.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)