You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/05/08 19:54:19 UTC
[GitHub] [superset] codecov[bot] commented on pull request #23971: fix: MySQL adjust_engine_params
codecov[bot] commented on PR #23971:
URL: https://github.com/apache/superset/pull/23971#issuecomment-1538956669
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/23971?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23971](https://app.codecov.io/gh/apache/superset/pull/23971?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (efd5986) into [master](https://app.codecov.io/gh/apache/superset/commit/9fd936c18c854a5a3c2f14c5cf13bd49e0fda6ab?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9fd936c) will **decrease** coverage by `11.39%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head efd5986 differs from pull request most recent head fe39012. Consider uploading reports for the commit fe39012 to get more accurate results
```diff
@@ Coverage Diff @@
## master #23971 +/- ##
===========================================
- Coverage 68.19% 56.80% -11.39%
===========================================
Files 1941 1941
Lines 75218 75218
Branches 8146 8146
===========================================
- Hits 51295 42729 -8566
- Misses 21845 30411 +8566
Partials 2078 2078
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.09% <0.00%> (ø)` | |
| python | `59.26% <100.00%> (-23.50%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `52.98% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/23971?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://app.codecov.io/gh/apache/superset/pull/23971?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `77.64% <100.00%> (-21.18%)` | :arrow_down: |
... and [307 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/23971/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org