[GitHub] [calcite] arnkore commented on a change in pull request #1515: fix some correlated subquery case's comment error

[GitBox <gi...@apache.org>]

arnkore commented on a change in pull request #1515: fix some correlated subquery case's comment error
URL: https://github.com/apache/calcite/pull/1515#discussion_r335932845
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rel/rules/SubQueryRemoveRule.java
 ##########
 @@ -235,9 +235,9 @@ private RexNode rewriteSome(RexSubQuery e, Set<CorrelationId> variablesSet,
       //   end as v
       // from emp as e
       // left outer join (
-      //   select max(deptno) as m, count(*) as c, count(deptno) as d,
+      //   select name, max(deptno) as m, count(*) as c, count(deptno) as d,
       //       "alwaysTrue" as indicator
-      //   group by name from emp) as q on e.name = q.name
+      //   from emp group by name) as q on e.name = q.name
 
 Review comment:
   > Thanks, there is no need to put `name` in the project list because it is already used as a group key.
   > 
   > BTW, this change is too small, can we merge it into a bigger one ?
   but, there isn't group key in implementation code 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services