You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by fe...@apache.org on 2022/04/29 04:55:18 UTC
[incubator-kyuubi] branch master updated: [KYUUBI #2450][FOLLOWUP] Remove opHandle from opHandleSet when exception occurs
This is an automated email from the ASF dual-hosted git repository.
feiwang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git
The following commit(s) were added to refs/heads/master by this push:
new 8e4a29549 [KYUUBI #2450][FOLLOWUP] Remove opHandle from opHandleSet when exception occurs
8e4a29549 is described below
commit 8e4a29549d80e639f0f6adfd6572713c066a5281
Author: wforget <64...@qq.com>
AuthorDate: Fri Apr 29 12:55:11 2022 +0800
[KYUUBI #2450][FOLLOWUP] Remove opHandle from opHandleSet when exception occurs
### _Why are the changes needed?_
Follow up #2450
In PR #2452, I add opHandle to opHandleSet before running, when running exception we need to remove opHandle from opHandleSet.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
Closes #2504 from wForget/KYUUBI-2450-1.
Closes #2450
a4ef89a7 [wforget] [KYUUBI-2450][FOLLOWUP] Remove Operation handle from opHandleSet when exception occurs
Authored-by: wforget <64...@qq.com>
Signed-off-by: Fei Wang <fw...@ebay.com>
---
.../src/main/scala/org/apache/kyuubi/session/AbstractSession.scala | 1 +
1 file changed, 1 insertion(+)
diff --git a/kyuubi-common/src/main/scala/org/apache/kyuubi/session/AbstractSession.scala b/kyuubi-common/src/main/scala/org/apache/kyuubi/session/AbstractSession.scala
index 270606b92..f1999f050 100644
--- a/kyuubi-common/src/main/scala/org/apache/kyuubi/session/AbstractSession.scala
+++ b/kyuubi-common/src/main/scala/org/apache/kyuubi/session/AbstractSession.scala
@@ -95,6 +95,7 @@ abstract class AbstractSession(
opHandle
} catch {
case e: KyuubiSQLException =>
+ opHandleSet.remove(operation.getHandle)
sessionManager.operationManager.closeOperation(operation.getHandle)
throw e
}