re: general/3872: util_script.c doubles up Set-Cookie headers from r->err_headers_out

[Dean Gaudet <dg...@arctic.org>]

The following reply was made to PR general/3872; it has been noted by GNATS.

From: Dean Gaudet <dg...@arctic.org>
To: Jeff Lewis <le...@stanford.edu>
Cc: apbugs@apache.org
Subject: re: general/3872: util_script.c doubles up Set-Cookie headers from r->err_headers_out
Date: Wed, 10 Mar 1999 10:05:48 -0800 (PST)

 Commenting out the ap_table_do line would pose troubles if there were two
 Set-Cookie headers already in err_headers_out... I'm pretty sure the patch
 below is the right way to fix it.  Can you test to make sure it works for
 you? 
 
 Thanks
 Dean
 
 Index: main/util_script.c
 ===================================================================
 RCS file: /home/cvs/apache-1.3/src/main/util_script.c,v
 retrieving revision 1.138
 diff -u -r1.138 util_script.c
 --- util_script.c	1999/02/05 00:37:48	1.138
 +++ util_script.c	1999/03/10 18:04:53
 @@ -496,6 +496,8 @@
  	    ap_overlap_tables(r->err_headers_out, merge,
  		AP_OVERLAP_TABLES_MERGE);
  	    if (!ap_is_empty_table(cookie_table)) {
 +		/* the cookies have already been copied to the cookie_table */
 +		ap_table_unset(r->err_headers_out, "Set-Cookie");
  		r->err_headers_out = ap_overlay_tables(r->pool,
  		    r->err_headers_out, cookie_table);
  	    }