You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Sunitha Kambhampati (JIRA)" <de...@db.apache.org> on 2006/03/01 19:03:05 UTC

[jira] Created: (DERBY-1071) Make UserAuthenticator javadoc mention clearly about what is passed in userName in authenticateUser

Make UserAuthenticator javadoc mention clearly about what is passed in userName in authenticateUser 
----------------------------------------------------------------------------------------------------

         Key: DERBY-1071
         URL: http://issues.apache.org/jira/browse/DERBY-1071
     Project: Derby
        Type: Task
  Components: Javadoc  
    Versions: 10.0.2.0, 10.0.2.1, 10.1.1.0, 10.1.1.1, 10.1.1.2, 10.1.2.0, 10.1.2.1, 10.1.2.2, 10.2.0.0    
 Environment: All
    Reporter: Sunitha Kambhampati
 Assigned to: Sunitha Kambhampati 
    Priority: Trivial
     Fix For: 10.2.0.0


Usernames passed to the UserAuthenticator#authenticateUser are passed as is from the connection url.  If the user name passed in has delimited quotes, then derby retains the delimiter quotes and passes it to UserAuthenticator#authenticateUser.

Javadoc for this method should mention this explicitly so users can write their authentication modules correctly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (DERBY-1071) Make UserAuthenticator javadoc mention clearly about what is passed in userName in authenticateUser

Posted by "Sunitha Kambhampati (JIRA)" <de...@db.apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-1071?page=all ]
     
Sunitha Kambhampati resolved DERBY-1071:
----------------------------------------

    Resolution: Fixed

Thanks Mike for committing this change.  I built javadoc and have verified it. 

> Make UserAuthenticator javadoc mention clearly about what is passed in userName in authenticateUser
> ---------------------------------------------------------------------------------------------------
>
>          Key: DERBY-1071
>          URL: http://issues.apache.org/jira/browse/DERBY-1071
>      Project: Derby
>         Type: Task
>   Components: Javadoc
>     Versions: 10.0.2.0, 10.0.2.1, 10.1.1.0, 10.2.0.0, 10.1.2.0, 10.1.1.1, 10.1.1.2, 10.1.2.1, 10.1.2.2
>  Environment: All
>     Reporter: Sunitha Kambhampati
>     Assignee: Sunitha Kambhampati
>     Priority: Trivial
>      Fix For: 10.2.0.0
>  Attachments: Derby1071.diff.txt, UserAuthenticator.html
>
> Usernames passed to the UserAuthenticator#authenticateUser are passed as is from the connection url.  If the user name passed in has delimited quotes, then derby retains the delimiter quotes and passes it to UserAuthenticator#authenticateUser.
> Javadoc for this method should mention this explicitly so users can write their authentication modules correctly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (DERBY-1071) Make UserAuthenticator javadoc mention clearly about what is passed in userName in authenticateUser

Posted by "Sunitha Kambhampati (JIRA)" <de...@db.apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-1071?page=all ]

Sunitha Kambhampati updated DERBY-1071:
---------------------------------------

    Attachment: Derby1071.diff.txt
                UserAuthenticator.html

I am attaching patch Derby1071.diff.txt to fix the javadoc for UserAuthenticator#authenticateUser

Derby passes the user in a connection request as is; to the authenticateUser method. Thus if user attribute value is delimited with quotes, the userName in authenticateUser will also be delimited. Mentioned this explicitly in the javadoc.

svn stat:
M      java\engine\org\apache\derby\authentication\UserAuthenticator.java

This is only a javadoc change. I built the javadoc ok (ant javadoc) and I have attached the UserAuthenticator.html also. 

Can someone please review and commit this change. Thanks.


> Make UserAuthenticator javadoc mention clearly about what is passed in userName in authenticateUser
> ---------------------------------------------------------------------------------------------------
>
>          Key: DERBY-1071
>          URL: http://issues.apache.org/jira/browse/DERBY-1071
>      Project: Derby
>         Type: Task
>   Components: Javadoc
>     Versions: 10.0.2.0, 10.0.2.1, 10.1.1.0, 10.1.1.1, 10.1.1.2, 10.1.2.0, 10.1.2.1, 10.1.2.2, 10.2.0.0
>  Environment: All
>     Reporter: Sunitha Kambhampati
>     Assignee: Sunitha Kambhampati
>     Priority: Trivial
>      Fix For: 10.2.0.0
>  Attachments: Derby1071.diff.txt, UserAuthenticator.html
>
> Usernames passed to the UserAuthenticator#authenticateUser are passed as is from the connection url.  If the user name passed in has delimited quotes, then derby retains the delimiter quotes and passes it to UserAuthenticator#authenticateUser.
> Javadoc for this method should mention this explicitly so users can write their authentication modules correctly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Reopened: (DERBY-1071) Make UserAuthenticator javadoc mention clearly about what is passed in userName in authenticateUser

Posted by "Sunitha Kambhampati (JIRA)" <de...@db.apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-1071?page=all ]
     
Sunitha Kambhampati reopened DERBY-1071:
----------------------------------------


> Make UserAuthenticator javadoc mention clearly about what is passed in userName in authenticateUser
> ---------------------------------------------------------------------------------------------------
>
>          Key: DERBY-1071
>          URL: http://issues.apache.org/jira/browse/DERBY-1071
>      Project: Derby
>         Type: Task
>   Components: Javadoc
>     Versions: 10.0.2.0, 10.0.2.1, 10.1.1.0, 10.1.1.1, 10.1.1.2, 10.1.2.0, 10.1.2.1, 10.1.2.2, 10.2.0.0
>  Environment: All
>     Reporter: Sunitha Kambhampati
>     Assignee: Sunitha Kambhampati
>     Priority: Trivial
>      Fix For: 10.2.0.0
>  Attachments: Derby1071.diff.txt, UserAuthenticator.html
>
> Usernames passed to the UserAuthenticator#authenticateUser are passed as is from the connection url.  If the user name passed in has delimited quotes, then derby retains the delimiter quotes and passes it to UserAuthenticator#authenticateUser.
> Javadoc for this method should mention this explicitly so users can write their authentication modules correctly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (DERBY-1071) Make UserAuthenticator javadoc mention clearly about what is passed in userName in authenticateUser

Posted by "Sunitha Kambhampati (JIRA)" <de...@db.apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-1071?page=all ]
     
Sunitha Kambhampati closed DERBY-1071:
--------------------------------------


> Make UserAuthenticator javadoc mention clearly about what is passed in userName in authenticateUser
> ---------------------------------------------------------------------------------------------------
>
>          Key: DERBY-1071
>          URL: http://issues.apache.org/jira/browse/DERBY-1071
>      Project: Derby
>         Type: Task
>   Components: Javadoc
>     Versions: 10.0.2.0, 10.0.2.1, 10.1.1.0, 10.2.0.0, 10.1.2.0, 10.1.1.1, 10.1.1.2, 10.1.2.1, 10.1.2.2
>  Environment: All
>     Reporter: Sunitha Kambhampati
>     Assignee: Sunitha Kambhampati
>     Priority: Trivial
>      Fix For: 10.2.0.0
>  Attachments: Derby1071.diff.txt, UserAuthenticator.html
>
> Usernames passed to the UserAuthenticator#authenticateUser are passed as is from the connection url.  If the user name passed in has delimited quotes, then derby retains the delimiter quotes and passes it to UserAuthenticator#authenticateUser.
> Javadoc for this method should mention this explicitly so users can write their authentication modules correctly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (DERBY-1071) Make UserAuthenticator javadoc mention clearly about what is passed in userName in authenticateUser

Posted by "Sunitha Kambhampati (JIRA)" <de...@db.apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-1071?page=all ]
     
Sunitha Kambhampati resolved DERBY-1071:
----------------------------------------

    Resolution: Fixed

> Make UserAuthenticator javadoc mention clearly about what is passed in userName in authenticateUser
> ---------------------------------------------------------------------------------------------------
>
>          Key: DERBY-1071
>          URL: http://issues.apache.org/jira/browse/DERBY-1071
>      Project: Derby
>         Type: Task
>   Components: Javadoc
>     Versions: 10.0.2.0, 10.0.2.1, 10.1.1.0, 10.1.1.1, 10.1.1.2, 10.1.2.0, 10.1.2.1, 10.1.2.2, 10.2.0.0
>  Environment: All
>     Reporter: Sunitha Kambhampati
>     Assignee: Sunitha Kambhampati
>     Priority: Trivial
>      Fix For: 10.2.0.0
>  Attachments: Derby1071.2.diff.txt, Derby1071.3.diff.txt, Derby1071.diff.txt, UserAuthenticator.html
>
> Usernames passed to the UserAuthenticator#authenticateUser are passed as is from the connection url.  If the user name passed in has delimited quotes, then derby retains the delimiter quotes and passes it to UserAuthenticator#authenticateUser.
> Javadoc for this method should mention this explicitly so users can write their authentication modules correctly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (DERBY-1071) Make UserAuthenticator javadoc mention clearly about what is passed in userName in authenticateUser

Posted by "Sunitha Kambhampati (JIRA)" <de...@db.apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-1071?page=all ]

Sunitha Kambhampati updated DERBY-1071:
---------------------------------------

    Attachment: Derby1071.2.diff.txt

Fix javadoc comment for authenticateUser#userName.

userName - The user's name for the connection request. May be null. The user name is passed in as is from the connection request. For example if user attribute is delimited with quotes is set as part of connection url or in the properties passed as part of DriverManager.getConnection(), then the userName passed here will also have the delimiter quotes. Derby will pass in the user name that is set on connection request without changing the casing.

Can someone please review and submit this change if it looks ok. Thanks. 

> Make UserAuthenticator javadoc mention clearly about what is passed in userName in authenticateUser
> ---------------------------------------------------------------------------------------------------
>
>          Key: DERBY-1071
>          URL: http://issues.apache.org/jira/browse/DERBY-1071
>      Project: Derby
>         Type: Task
>   Components: Javadoc
>     Versions: 10.0.2.0, 10.0.2.1, 10.1.1.0, 10.1.1.1, 10.1.1.2, 10.1.2.0, 10.1.2.1, 10.1.2.2, 10.2.0.0
>  Environment: All
>     Reporter: Sunitha Kambhampati
>     Assignee: Sunitha Kambhampati
>     Priority: Trivial
>      Fix For: 10.2.0.0
>  Attachments: Derby1071.2.diff.txt, Derby1071.diff.txt, UserAuthenticator.html
>
> Usernames passed to the UserAuthenticator#authenticateUser are passed as is from the connection url.  If the user name passed in has delimited quotes, then derby retains the delimiter quotes and passes it to UserAuthenticator#authenticateUser.
> Javadoc for this method should mention this explicitly so users can write their authentication modules correctly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (DERBY-1071) Make UserAuthenticator javadoc mention clearly about what is passed in userName in authenticateUser

Posted by "Sunitha Kambhampati (JIRA)" <de...@db.apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-1071?page=all ]

Sunitha Kambhampati updated DERBY-1071:
---------------------------------------

    Attachment: Derby1071.3.diff.txt

I am attaching a new version of this patch to fix the javadoc. -Derby1071.3.diff.txt.   

This is only a javadoc change for UserAuthenticator#authenticateUser method. 

Can someone please review and commit it. Thanks. 

> Make UserAuthenticator javadoc mention clearly about what is passed in userName in authenticateUser
> ---------------------------------------------------------------------------------------------------
>
>          Key: DERBY-1071
>          URL: http://issues.apache.org/jira/browse/DERBY-1071
>      Project: Derby
>         Type: Task
>   Components: Javadoc
>     Versions: 10.0.2.0, 10.0.2.1, 10.1.1.0, 10.1.1.1, 10.1.1.2, 10.1.2.0, 10.1.2.1, 10.1.2.2, 10.2.0.0
>  Environment: All
>     Reporter: Sunitha Kambhampati
>     Assignee: Sunitha Kambhampati
>     Priority: Trivial
>      Fix For: 10.2.0.0
>  Attachments: Derby1071.2.diff.txt, Derby1071.3.diff.txt, Derby1071.diff.txt, UserAuthenticator.html
>
> Usernames passed to the UserAuthenticator#authenticateUser are passed as is from the connection url.  If the user name passed in has delimited quotes, then derby retains the delimiter quotes and passes it to UserAuthenticator#authenticateUser.
> Javadoc for this method should mention this explicitly so users can write their authentication modules correctly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (DERBY-1071) Make UserAuthenticator javadoc mention clearly about what is passed in userName in authenticateUser

Posted by "Sunitha Kambhampati (JIRA)" <de...@db.apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-1071?page=all ]
     
Sunitha Kambhampati closed DERBY-1071:
--------------------------------------


> Make UserAuthenticator javadoc mention clearly about what is passed in userName in authenticateUser
> ---------------------------------------------------------------------------------------------------
>
>          Key: DERBY-1071
>          URL: http://issues.apache.org/jira/browse/DERBY-1071
>      Project: Derby
>         Type: Task

>   Components: Javadoc
>     Versions: 10.0.2.0, 10.0.2.1, 10.1.1.0, 10.1.1.1, 10.1.1.2, 10.1.2.0, 10.1.2.1, 10.1.2.2, 10.2.0.0
>  Environment: All
>     Reporter: Sunitha Kambhampati
>     Assignee: Sunitha Kambhampati
>     Priority: Trivial
>      Fix For: 10.2.0.0
>  Attachments: Derby1071.2.diff.txt, Derby1071.3.diff.txt, Derby1071.diff.txt, UserAuthenticator.html
>
> Usernames passed to the UserAuthenticator#authenticateUser are passed as is from the connection url.  If the user name passed in has delimited quotes, then derby retains the delimiter quotes and passes it to UserAuthenticator#authenticateUser.
> Javadoc for this method should mention this explicitly so users can write their authentication modules correctly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira