You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2018/10/05 07:06:43 UTC

[kudu-CR] Move constructor and assignment operator for Schema

Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11593

to look at the new patch set (#3).

Change subject: Move constructor and assignment operator for Schema
......................................................................

Move constructor and assignment operator for Schema

This adds a move constructor and move assignment operator to Schema.

I removed Schema::swap. It was only used in tests, and any potential
use of it should be adequately fulfilled by one of moves, copies, or
Schema::Reset.

Change-Id: I6c827c84657875be4cf2bc565db03a686849d8e2
---
M src/kudu/common/id_mapping.h
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
M src/kudu/common/schema.h
4 files changed, 109 insertions(+), 56 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/11593/3
-- 
To view, visit http://gerrit.cloudera.org:8080/11593
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6c827c84657875be4cf2bc565db03a686849d8e2
Gerrit-Change-Number: 11593
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot