You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2022/01/26 05:23:03 UTC
[GitHub] [cassandra] yashLadha opened a new pull request #1427: Remove default_time_to_live for Views in describe
yashLadha opened a new pull request #1427:
URL: https://github.com/apache/cassandra/pull/1427
Remove default_time_to_live in the describe output for views as it is
not supported by them. Updated to pass the isView variable to the
CqlBuilder.
Fixes: https://issues.apache.org/jira/browse/CASSANDRA-17266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] yashLadha commented on pull request #1427: Remove default_time_to_live for Views in describe
Posted by GitBox <gi...@apache.org>.
yashLadha commented on pull request #1427:
URL: https://github.com/apache/cassandra/pull/1427#issuecomment-1022143064
@blerer Updated the `testDescribeRoundtrip()` test with materialized view creation and assertion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] driftx commented on a change in pull request #1427: Remove default_time_to_live for Views in describe
Posted by GitBox <gi...@apache.org>.
driftx commented on a change in pull request #1427:
URL: https://github.com/apache/cassandra/pull/1427#discussion_r795863641
##########
File path: src/java/org/apache/cassandra/schema/TableParams.java
##########
@@ -273,26 +273,31 @@ public void appendCqlTo(CqlBuilder builder)
.append("AND compression = ").append(compression.asMap())
.newLine()
.append("AND crc_check_chance = ").append(crcCheckChance)
- .newLine()
+ .newLine();
+
+ if (!isView) {
Review comment:
Brace should be on newline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] blerer commented on a change in pull request #1427: Remove default_time_to_live for Views in describe
Posted by GitBox <gi...@apache.org>.
blerer commented on a change in pull request #1427:
URL: https://github.com/apache/cassandra/pull/1427#discussion_r795896650
##########
File path: src/java/org/apache/cassandra/schema/TableParams.java
##########
@@ -273,26 +273,31 @@ public void appendCqlTo(CqlBuilder builder)
.append("AND compression = ").append(compression.asMap())
.newLine()
.append("AND crc_check_chance = ").append(crcCheckChance)
- .newLine()
+ .newLine();
+
+ if (!isView) {
Review comment:
I can take care of that on commit :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org