You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2022/04/21 08:34:23 UTC

[GitHub] [hbase] comnetwork commented on pull request #4355: HBASE-26960 Another case for unnecessary replication suspending in Re…

comnetwork commented on PR #4355:
URL: https://github.com/apache/hbase/pull/4355#issuecomment-1104874108

   @Apache9 ,  `RegionReplicationSink.add`  is  invoked by `MultiVersionConcurrencyControl.complete(WriteEntry)`, so it seems not very elegant and somewhat tricky to not write WAL but still invoke `RegionReplicationSink.add`.
   
   I think we could  add an overload `MemStoreFlusher.requestFlush` to accept the `writeFlushRequestWalMarker` paramter，just some modifications for {{MemStoreFlusher}}, I think seems it is more suitable than doing some trick to not write WAL but still invoke `RegionReplicationSink.add`? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org