You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2014/08/13 21:44:01 UTC
Review Request 24663: Alerts: Calculate Hash Based On Alert Definitions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24663/
-----------------------------------------------------------
Review request for Ambari and Nate Cole.
Bugs: AMBARI-6853
https://issues.apache.org/jira/browse/AMBARI-6853
Repository: ambari
Description
-------
A "meta hash" will be used to track the state of the alert definitions for a given host. Each host will have all of the alert definitions that should be running on it represented by a single hash of all of the definition GUIDs.
The hash will be sent in each heartbeat response. It will be calculated and kept in memory in Map<Host,Hash>.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java fa633c1
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatResponse.java 1670beb
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java 6f00c27
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java 05881e4
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java de30921
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionHash.java PRE-CREATION
ambari-server/src/main/resources/properties.json e515b91
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java fc57389
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java f2ddcd7
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertDefinitionHashTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/24663/diff/
Testing
-------
Manually ran alert provider/ORM/hash tests.
Thanks,
Jonathan Hurley
Re: Review Request 24663: Alerts: Calculate Hash Based On Alert Definitions
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24663/#review50499
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Aug. 13, 2014, 3:43 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24663/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2014, 3:43 p.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-6853
> https://issues.apache.org/jira/browse/AMBARI-6853
>
>
> Repository: ambari
>
>
> Description
> -------
>
> A "meta hash" will be used to track the state of the alert definitions for a given host. Each host will have all of the alert definitions that should be running on it represented by a single hash of all of the definition GUIDs.
> The hash will be sent in each heartbeat response. It will be calculated and kept in memory in Map<Host,Hash>.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java fa633c1
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatResponse.java 1670beb
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java 6f00c27
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java 05881e4
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java de30921
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionHash.java PRE-CREATION
> ambari-server/src/main/resources/properties.json e515b91
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java fc57389
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java f2ddcd7
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertDefinitionHashTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/24663/diff/
>
>
> Testing
> -------
>
> Manually ran alert provider/ORM/hash tests.
>
>
> Thanks,
>
> Jonathan Hurley
>
>