You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by si...@apache.org on 2021/11/09 17:18:30 UTC
[pulsar-helm-chart] branch master updated: Missing fix for #152.
Bookie Service also needs the prefix on the port name (#172)
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-helm-chart.git
The following commit(s) were added to refs/heads/master by this push:
new 6173081 Missing fix for #152. Bookie Service also needs the prefix on the port name (#172)
6173081 is described below
commit 617308147db8dcbcbb72201792756c862790b97e
Author: Frank Kelly <62...@users.noreply.github.com>
AuthorDate: Tue Nov 9 12:18:26 2021 -0500
Missing fix for #152. Bookie Service also needs the prefix on the port name (#172)
Fixes #158 (This is the second PR - see also https://github.com/apache/pulsar-helm-chart/pull/162)
### Motivation
* All non-standard port-names need a proper protocol prefix to support Istio
https://istio.io/latest/docs/ops/configuration/traffic-management/protocol-selection/#explicit-protocol-selection
### Modifications
Add the prefix value before `bookie`
---
charts/pulsar/Chart.yaml | 2 +-
charts/pulsar/templates/bookkeeper-service.yaml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/charts/pulsar/Chart.yaml b/charts/pulsar/Chart.yaml
index f8bb972..4265d63 100644
--- a/charts/pulsar/Chart.yaml
+++ b/charts/pulsar/Chart.yaml
@@ -21,7 +21,7 @@ apiVersion: v1
appVersion: "2.7.2"
description: Apache Pulsar Helm chart for Kubernetes
name: pulsar
-version: 2.7.3
+version: 2.7.4
home: https://pulsar.apache.org
sources:
- https://github.com/apache/pulsar
diff --git a/charts/pulsar/templates/bookkeeper-service.yaml b/charts/pulsar/templates/bookkeeper-service.yaml
index 3bf9495..c434a4b 100644
--- a/charts/pulsar/templates/bookkeeper-service.yaml
+++ b/charts/pulsar/templates/bookkeeper-service.yaml
@@ -32,7 +32,7 @@ metadata:
{{- end }}
spec:
ports:
- - name: bookie
+ - name: "{{ .Values.tcpPrefix }}bookie"
port: {{ .Values.bookkeeper.ports.bookie }}
- name: http
port: {{ .Values.bookkeeper.ports.http }}