You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/23 08:58:09 UTC
[GitHub] [spark] PavithraRamachandran commented on a change in pull request
#26222: [SPARK-29504][WebUI]show full decription when double click on ellipse
PavithraRamachandran commented on a change in pull request #26222: [SPARK-29504][WebUI]show full decription when double click on ellipse
URL: https://github.com/apache/spark/pull/26222#discussion_r337926544
##########
File path: core/src/main/resources/org/apache/spark/ui/static/webui.js
##########
@@ -87,4 +87,11 @@ $(function() {
collapseTablePageLoad('collapse-aggregated-runningExecutions','aggregated-runningExecutions');
collapseTablePageLoad('collapse-aggregated-completedExecutions','aggregated-completedExecutions');
collapseTablePageLoad('collapse-aggregated-failedExecutions','aggregated-failedExecutions');
-});
\ No newline at end of file
+});
+
+$(function() {
+ // Trigger a double click on the span to show full job description.
+ $(".description-input").dblclick(function() {
+ $(this).removeClass("description-input").addClass("description-input-full");
+ });
+});
Review comment:
@wangyum yes. It was present. But
https://github.com/apache/spark/pull/25374/files
removed additonal-metrics.js whch had the function for this double click event.
So this feature was broken.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org