[GitHub] [storm] kishorvpatil commented on a change in pull request #3022: STORM-3407 Storm 2.x ConstraintSolverStrategy backward compatibility

[GitBox <gi...@apache.org>]

kishorvpatil commented on a change in pull request #3022: STORM-3407 Storm 2.x ConstraintSolverStrategy backward compatibility
URL: https://github.com/apache/storm/pull/3022#discussion_r291713047
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/ConstraintSolverStrategy.java
 ##########
 @@ -248,10 +247,22 @@ public SchedulingResult schedule(Cluster cluster, TopologyDetails td) {
         nodes = RAS_Nodes.getAllNodesFrom(cluster);
         Map<WorkerSlot, Set<String>> workerCompAssignment = new HashMap<>();
         Map<RAS_Node, Set<String>> nodeCompAssignment = new HashMap<>();
-        //set max number of states to search
-        final int maxStateSearch = Math.min(MAX_STATE_SEARCH,
-                                            ObjectReader.getInt(td.getConf().get(Config.TOPOLOGY_RAS_CONSTRAINT_MAX_STATE_SEARCH),
-                                                                DEFAULT_STATE_SEARCH));
 
 Review comment:
   We still need defaults.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services