You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/08/30 03:04:28 UTC

[GitHub] [ratis] captainzmc commented on pull request #718: RATIS-1677. Do not auto format RaftStorage in RECOVER.

captainzmc commented on PR #718:
URL: https://github.com/apache/ratis/pull/718#issuecomment-1231085803

   Hi @szetszwo, thank you for this fix.
   I tested Ratis-2.4.0 rc1 in ozone and I found that we cherry-pick this patch into 2.4.0 release branch.
   There are two possible problems here:
   1. The interface compatibility issues, ozone is directly use [GroupManagementRequest.newAdd](https://github.com/captainzmc/hadoop-ozone/commit/bfa69f788d9f9c82218e5a8dc2801a33893df9f2#diff-7048844bed8c3f7f0689c28cdd4edd3ac3a70139e3c01b87fd79add572315ed3R754), this method changes in the PR maybe not compatible.
   2. Regardless of whether I set the format in newAdd to true or false, I will see many “Storage directory not found” exceptions in the UT of Ozone. （See the test UT, [set format to false](https://github.com/captainzmc/hadoop-ozone/runs/8072516884?check_suite_focus=true#step:5:9813) and [set format to true](https://github.com/captainzmc/hadoop-ozone/runs/8072573474?check_suite_focus=true#step:5:5170) ）
   So do we need to revert this Commit revert in 2.4.0 branch? cc @codings-dan @adoroszlai 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org