You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/01 19:06:58 UTC

[GitHub] [airflow] XD-DENG opened a new pull request #15143: Fix password masking in CLI action_logging

XD-DENG opened a new pull request #15143:
URL: https://github.com/apache/airflow/pull/15143

closes: #15131

Currently as long as argument '-p' if present, code tries to mask it.
However, '-p' may mean something else (not password), like a boolean flag. Such cases may result in exception.

More detailed analysis can be found in issue https://github.com/apache/airflow/issues/15131#issuecomment-812109409

The solution here is to only try masking the next arg when we are sure `-p` means "password".

<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.

Feel free to ping committers for the review!

In case of existing issue, reference it using one of the following:

closes: #ISSUE
related: #ISSUE

How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->

---
**^ Add meaningful description above**

Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] XD-DENG commented on pull request #15143: Fix password masking in CLI action_logging

Posted by GitBox <gi...@apache.org>.

XD-DENG commented on pull request #15143:
URL: https://github.com/apache/airflow/pull/15143#issuecomment-812145316


   > Worth adding tests do you think?
   
   Added in https://github.com/apache/airflow/pull/15143/commits/6b1f641b0fd44d38fb7d745a6bb3e6a903aab887


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] XD-DENG commented on pull request #15143: Fix password masking in CLI action_logging

Posted by GitBox <gi...@apache.org>.

XD-DENG commented on pull request #15143:
URL: https://github.com/apache/airflow/pull/15143#issuecomment-812140247


   @ashb yep, I agree it's worth adding test(s). I was thinking about it when I was preparing the PR, but still trying figure out how to do it in the most proper way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] XD-DENG merged pull request #15143: Fix password masking in CLI action_logging

Posted by GitBox <gi...@apache.org>.

XD-DENG merged pull request #15143:
URL: https://github.com/apache/airflow/pull/15143


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] XD-DENG commented on pull request #15143: Fix password masking in CLI action_logging

Posted by GitBox <gi...@apache.org>.

XD-DENG commented on pull request #15143:
URL: https://github.com/apache/airflow/pull/15143#issuecomment-812142141


   Ha, I think the adding more cases to `test_cli_create_user_supplied_password_is_masked` would be sufficient. I overlooked it just now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org