You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Peter Major (JIRA)" <ji...@apache.org> on 2017/12/29 19:28:00 UTC

[jira] [Commented] (WICKET-6321) Support Integrity and Crossorigin attributes for JavaScriptUrlReferenceHeaderItem

    [ https://issues.apache.org/jira/browse/WICKET-6321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16306479#comment-16306479 ] 

Peter Major commented on WICKET-6321:
-------------------------------------

I'm thinking about implementing this, this is what I came up with so far:
Looks like JavaScriptUtils has quite a lot of method arguments already and I'm thinking about creating a new POJO ExternalJavaScript, however I struggled to find Builders in the Wicket codebase, instead it seems like that mutable builder-like objects are more preferred.
The problem then is that the serialization of the ExternalJavaScript object would be best done in the object itself, but then that would probably result in some code duplication with JavaScriptUtils serializing in-line JS.

What would be the preferred way to implement this feature?

> Support Integrity and Crossorigin attributes for JavaScriptUrlReferenceHeaderItem 
> ----------------------------------------------------------------------------------
>
>                 Key: WICKET-6321
>                 URL: https://issues.apache.org/jira/browse/WICKET-6321
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 8.0.0-M3
>            Reporter: Mikhail Fursov
>
> Example of secure script reference:
> <script src="https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/4.0.0-alpha.6/js/bootstrap.min.js" integrity="sha256-+kIbbrvS+0dNOjhmQJzmwe/RILR/8lb/+4+PUNVW09k=" crossorigin="anonymous"></script>



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)