[jira] [Commented] (NIFI-4389) Ivy library should be added in scripted NARs to allow use Grape/Grab with Groovy

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16310058#comment-16310058 ] 

ASF GitHub Bot commented on NIFI-4389:
--------------------------------------

GitHub user mattyb149 opened a pull request:

    https://github.com/apache/nifi/pull/2368

    NIFI-4389: Add Ivy to scripting NARs for Grape/Grab in Groovy

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [x] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [x] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mattyb149/nifi NIFI-4389

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2368.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2368
    
----
commit c4139eb459681dc1fddd62de6ff0242c8e7122b3
Author: Matthew Burgess <ma...@...>
Date:   2018-01-03T18:46:30Z

    NIFI-4389: Add Ivy to scripting NARs for Grape/Grab in Groovy

----


> Ivy library should be added in scripted NARs to allow use Grape/Grab with Groovy
> --------------------------------------------------------------------------------
>
>                 Key: NIFI-4389
>                 URL: https://issues.apache.org/jira/browse/NIFI-4389
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>            Reporter: Patrice Freydiere
>            Assignee: Matt Burgess
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> When using @Grap groovy annotation to add third party dependency library cause a ClassNotFoundException on ivy class.
> adding Ivy dependency in /lib folder fix the issue and permit to use third party libraries



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)