You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2012/11/29 01:51:51 UTC

Review Request: SQOOP-728 Increase varchar limits for external link and exceptions in Derby repository

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8257/
-----------------------------------------------------------

Review request for Sqoop.


Description
-------

I've increased the size of those three columns in submission table and made sure that we won't be saving longer strings.


This addresses bug SQOOP-728.
    https://issues.apache.org/jira/browse/SQOOP-728


Diffs
-----

  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 55d7128 

Diff: https://reviews.apache.org/r/8257/diff/


Testing
-------

Unit tests are passing and tested on real cluster.


Thanks,

Jarek Cecho


Re: Review Request: SQOOP-728 Increase varchar limits for external link and exceptions in Derby repository

Posted by Bilung Lee <bl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8257/#review13879
-----------------------------------------------------------

Ship it!


Ship It!

- Bilung Lee


On Nov. 29, 2012, 12:51 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8257/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2012, 12:51 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've increased the size of those three columns in submission table and made sure that we won't be saving longer strings.
> 
> 
> This addresses bug SQOOP-728.
>     https://issues.apache.org/jira/browse/SQOOP-728
> 
> 
> Diffs
> -----
> 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 55d7128 
> 
> Diff: https://reviews.apache.org/r/8257/diff/
> 
> 
> Testing
> -------
> 
> Unit tests are passing and tested on real cluster.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>