You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/01 13:25:35 UTC
[GitHub] [arrow] okadakk opened a new pull request #12529: ARROW-15749: [Ruby] Add support for #values of Month Interval Type
okadakk opened a new pull request #12529:
URL: https://github.com/apache/arrow/pull/12529
Implement values method of month interval type to red arrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #12529: ARROW-15749: [Ruby] Add support for #values of Month Interval Type
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #12529:
URL: https://github.com/apache/arrow/pull/12529#discussion_r821321192
##########
File path: ruby/red-arrow/ext/arrow/converters.hpp
##########
@@ -202,6 +202,13 @@ namespace red_arrow {
// const int64_t i) {
// };
+
Review comment:
```suggestion
```
##########
File path: ruby/red-arrow/ext/arrow/converters.hpp
##########
@@ -202,6 +202,13 @@ namespace red_arrow {
// const int64_t i) {
// };
+
+ inline VALUE convert(const arrow::MonthIntervalArray& array,
+ const int64_t i) {
+ return INT2NUM(array.Value(i));
+ }
+
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #12529: ARROW-15749: [Ruby] Add support for #values of Month Interval Type
Posted by GitBox <gi...@apache.org>.
kou closed pull request #12529:
URL: https://github.com/apache/arrow/pull/12529
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12529: ARROW-15749: [Ruby] Add support for #values of Month Interval Type
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12529:
URL: https://github.com/apache/arrow/pull/12529#issuecomment-1061408233
Benchmark runs are scheduled for baseline = 11d2e4863974b95c1fa637e83757b98f291366c3 and contender = 63e1accbfc001527d61b2b5b8ed72d6041f7e82b. 63e1accbfc001527d61b2b5b8ed72d6041f7e82b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/a6e3d53c954644718b5112bbece29cae...419f95b5ea874dba9aed7ba2b31edda6/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2f822dea637a438bacc8c6dd0498c2f2...be3651df94604bbbb6805d433699d72b/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f0f448656ae741179fe0d02a19fcfc06...aa939d17342243b9b6c13f7b4b4d9f50/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8b40f284bad54e82aa811086ebb44dfc...cc1c8116fb2240918adeb286616109c2/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12529: ARROW-15749: [Ruby] Add support for #values of Month Interval Type
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12529:
URL: https://github.com/apache/arrow/pull/12529#issuecomment-1055451874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12529: ARROW-15749: [Ruby] Add support for #values of Month Interval Type
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12529:
URL: https://github.com/apache/arrow/pull/12529#issuecomment-1061408233
Benchmark runs are scheduled for baseline = 11d2e4863974b95c1fa637e83757b98f291366c3 and contender = 63e1accbfc001527d61b2b5b8ed72d6041f7e82b. 63e1accbfc001527d61b2b5b8ed72d6041f7e82b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/a6e3d53c954644718b5112bbece29cae...419f95b5ea874dba9aed7ba2b31edda6/)
[Finished :arrow_down:0.38% :arrow_up:0.17%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2f822dea637a438bacc8c6dd0498c2f2...be3651df94604bbbb6805d433699d72b/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f0f448656ae741179fe0d02a19fcfc06...aa939d17342243b9b6c13f7b4b4d9f50/)
[Finished :arrow_down:0.09% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8b40f284bad54e82aa811086ebb44dfc...cc1c8116fb2240918adeb286616109c2/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12529: ARROW-15749: [Ruby] Add support for #values of Month Interval Type
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12529:
URL: https://github.com/apache/arrow/pull/12529#issuecomment-1061408233
Benchmark runs are scheduled for baseline = 11d2e4863974b95c1fa637e83757b98f291366c3 and contender = 63e1accbfc001527d61b2b5b8ed72d6041f7e82b. 63e1accbfc001527d61b2b5b8ed72d6041f7e82b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/a6e3d53c954644718b5112bbece29cae...419f95b5ea874dba9aed7ba2b31edda6/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2f822dea637a438bacc8c6dd0498c2f2...be3651df94604bbbb6805d433699d72b/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f0f448656ae741179fe0d02a19fcfc06...aa939d17342243b9b6c13f7b4b4d9f50/)
[Finished :arrow_down:0.09% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8b40f284bad54e82aa811086ebb44dfc...cc1c8116fb2240918adeb286616109c2/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12529: ARROW-15749: [Ruby] Add support for #values of Month Interval Type
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12529:
URL: https://github.com/apache/arrow/pull/12529#issuecomment-1061408233
Benchmark runs are scheduled for baseline = 11d2e4863974b95c1fa637e83757b98f291366c3 and contender = 63e1accbfc001527d61b2b5b8ed72d6041f7e82b. 63e1accbfc001527d61b2b5b8ed72d6041f7e82b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/a6e3d53c954644718b5112bbece29cae...419f95b5ea874dba9aed7ba2b31edda6/)
[Finished :arrow_down:0.38% :arrow_up:0.17%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2f822dea637a438bacc8c6dd0498c2f2...be3651df94604bbbb6805d433699d72b/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f0f448656ae741179fe0d02a19fcfc06...aa939d17342243b9b6c13f7b4b4d9f50/)
[Finished :arrow_down:0.09% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8b40f284bad54e82aa811086ebb44dfc...cc1c8116fb2240918adeb286616109c2/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12529: ARROW-15749: [Ruby] Add support for #values of Month Interval Type
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12529:
URL: https://github.com/apache/arrow/pull/12529#issuecomment-1061408233
Benchmark runs are scheduled for baseline = 11d2e4863974b95c1fa637e83757b98f291366c3 and contender = 63e1accbfc001527d61b2b5b8ed72d6041f7e82b. 63e1accbfc001527d61b2b5b8ed72d6041f7e82b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/a6e3d53c954644718b5112bbece29cae...419f95b5ea874dba9aed7ba2b31edda6/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2f822dea637a438bacc8c6dd0498c2f2...be3651df94604bbbb6805d433699d72b/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f0f448656ae741179fe0d02a19fcfc06...aa939d17342243b9b6c13f7b4b4d9f50/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8b40f284bad54e82aa811086ebb44dfc...cc1c8116fb2240918adeb286616109c2/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] okadakk commented on pull request #12529: ARROW-15749: [Ruby] Add support for #values of Month Interval Type
Posted by GitBox <gi...@apache.org>.
okadakk commented on pull request #12529:
URL: https://github.com/apache/arrow/pull/12529#issuecomment-1062933581
Thank you!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org