You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2017/11/16 13:27:08 UTC
Review Request 63876: ambari-server upgrade to 2.6.1 should surface
the GPL agreement
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63876/
-----------------------------------------------------------
Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid Wagle.
Bugs: AMBARI-22454
https://issues.apache.org/jira/browse/AMBARI-22454
Repository: ambari
Description
-------
* ambari-server upgrade should determine whether lzo is enabled.
* If yes: Surface the same agreement as the setup step
* If no: Provide link to the documentation to disable lzo configuration and cleanup local repositories.
Since this involves reading from the database we should think of sending back
data on the pipe as stdout from the upgrade jvm and the python process.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java dac871ea28
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java a2dea40f58
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog.java 21273fd49a
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog261.java PRE-CREATION
ambari-server/src/main/python/ambari_server/serverConfiguration.py 262e9447e5
ambari-server/src/main/python/ambari_server/serverSetup.py 8a14066a66
ambari-server/src/main/python/ambari_server/serverUpgrade.py 421adfc4a1
Diff: https://reviews.apache.org/r/63876/diff/1/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 63876: ambari-server upgrade to 2.6.1 should
surface the GPL agreement
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63876/#review191221
-----------------------------------------------------------
Fix it, then Ship it!
Just minor typos.
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog261.java
Lines 41 (patched)
<https://reviews.apache.org/r/63876/#comment268886>
LZO_ENABLED_JSON_KEY
ambari-server/src/main/python/ambari_server/serverUpgrade.py
Lines 77 (patched)
<https://reviews.apache.org/r/63876/#comment268884>
By saying no, ...
- Nate Cole
On Nov. 16, 2017, 8:27 a.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63876/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2017, 8:27 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid Wagle.
>
>
> Bugs: AMBARI-22454
> https://issues.apache.org/jira/browse/AMBARI-22454
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * ambari-server upgrade should determine whether lzo is enabled.
> * If yes: Surface the same agreement as the setup step
> * If no: Provide link to the documentation to disable lzo configuration and cleanup local repositories.
>
> Since this involves reading from the database we should think of sending back
> data on the pipe as stdout from the upgrade jvm and the python process.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java dac871ea28
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java a2dea40f58
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog.java 21273fd49a
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog261.java PRE-CREATION
> ambari-server/src/main/python/ambari_server/serverConfiguration.py 262e9447e5
> ambari-server/src/main/python/ambari_server/serverSetup.py 8a14066a66
> ambari-server/src/main/python/ambari_server/serverUpgrade.py 421adfc4a1
>
>
> Diff: https://reviews.apache.org/r/63876/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 63876: ambari-server upgrade to 2.6.1 should
surface the GPL agreement
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63876/#review191210
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog261.java
Lines 32 (patched)
<https://reviews.apache.org/r/63876/#comment268862>
This import ordering might not conform to those enforced by ambari-utility, make sure to address it in your IDE.
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog261.java
Lines 90 (patched)
<https://reviews.apache.org/r/63876/#comment268870>
To make this future proof we should have a cluter map returned but for now lets add a TODO for it.
- Sid Wagle
On Nov. 16, 2017, 1:27 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63876/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2017, 1:27 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid Wagle.
>
>
> Bugs: AMBARI-22454
> https://issues.apache.org/jira/browse/AMBARI-22454
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * ambari-server upgrade should determine whether lzo is enabled.
> * If yes: Surface the same agreement as the setup step
> * If no: Provide link to the documentation to disable lzo configuration and cleanup local repositories.
>
> Since this involves reading from the database we should think of sending back
> data on the pipe as stdout from the upgrade jvm and the python process.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java dac871ea28
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java a2dea40f58
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog.java 21273fd49a
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog261.java PRE-CREATION
> ambari-server/src/main/python/ambari_server/serverConfiguration.py 262e9447e5
> ambari-server/src/main/python/ambari_server/serverSetup.py 8a14066a66
> ambari-server/src/main/python/ambari_server/serverUpgrade.py 421adfc4a1
>
>
> Diff: https://reviews.apache.org/r/63876/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>