You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/05/27 03:01:15 UTC

[kudu-CR] log: Mark allocation finished even if allocation had an error

Hello Adar Dembo, Todd Lipcon,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/3234

to review the following change.

Change subject: log: Mark allocation finished even if allocation had an error
......................................................................

log: Mark allocation finished even if allocation had an error

The problem this patch fixes is that if a disk preallocation fails we
will enter a "stuck" state where we cannot preallocate a new segment.
Errors to allocate or append should be fatal.

A test exercising this code path is in a follow-up patch related to disk
reservations. Since this is a bug fix, it seemed cleaner to separate it
out into its own commit.

Change-Id: If22bf946a42d0ec32c35164acd9e6e6cef18dcc3
---
M src/kudu/consensus/log.cc
1 file changed, 9 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/3234/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If22bf946a42d0ec32c35164acd9e6e6cef18dcc3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>