You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "hernanDatgDev (via GitHub)" <gi...@apache.org> on 2024/06/17 23:32:46 UTC
[I] Add support for mounting volumes with mount trait [camel-k]
hernanDatgDev opened a new issue, #5654:
URL: https://github.com/apache/camel-k/issues/5654
### Requirement
As a developer I want a way to add volume references to my integrations and also use the mount trait to mount configmaps/secrets. Currently this is not possible without interfering with the mount trait.
### Problem
The pod template can be used to add volume references to an integration however this overrides any volumes/mounts that are set with the mount trait. This leaves a situation where a configmap can be mounted through the mount trait, a pod template can define an `emptyDir` volume and only the `emptyDir` from the template will actually propagate to the integration pod resulting in failures.
### Proposal
A suggestion from [Zulip](https://camel.zulipchat.com/#narrow/stream/257299-camel-k/topic/pod.20template.20volume.20overrides.20mount.20trait/near/444404000) is to enhance the mount trait to allow for volume support in addition to the existing persistent-volume-claim support.
### Open questions
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add support for mounting volumes with mount trait [camel-k]
Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on issue #5654:
URL: https://github.com/apache/camel-k/issues/5654#issuecomment-2248543135
Hi @hernanDatgDev, thank you for taking care of it! Don't hesitate to submit a PR even if you are still working on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add support for mounting volumes with mount trait [camel-k]
Posted by "mdebarros (via GitHub)" <gi...@apache.org>.
mdebarros commented on issue #5654:
URL: https://github.com/apache/camel-k/issues/5654#issuecomment-2239341363
Hi @squakez,
Do you have a target release for this feature?
This feature is currently needed to enabled several Sourceless capabilities:
1. Security hardening to support `readOnlyRootFilesystem=false`, based on this discussion --> https://camel.zulipchat.com/#narrow/stream/257299-camel-k/topic/pod.20template.20volume.20overrides.20mount.20trait/near/444404000
2. This would also enable some other use-cases where we want to use init-containers to inject jvmAgents, such as Jolokia.
It would be awesome if we could target this to be part of 2.4.0.
Kind Regards,
Miguel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add support for mounting volumes with mount trait [camel-k]
Posted by "hernanDatgDev (via GitHub)" <gi...@apache.org>.
hernanDatgDev commented on issue #5654:
URL: https://github.com/apache/camel-k/issues/5654#issuecomment-2248425604
Hey @squakez I started work on this and have basically added a case for the emptyDir volume in `pkg/trait/trait_types.go getVolume()` alongside the other types: configmap, secret, and pvc
I'm in the process of creating a PR but want to get some feedback if this is the expected approach for adding the volume support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add support for mounting volumes with mount trait [camel-k]
Posted by "hernanDatgDev (via GitHub)" <gi...@apache.org>.
hernanDatgDev commented on issue #5654:
URL: https://github.com/apache/camel-k/issues/5654#issuecomment-2251514808
@gansheer Thanks for the heads up. Just created a PR with some comments: https://github.com/apache/camel-k/pull/5709
I did run into what I believe is a bug with the `kamel promote` command. Will be creating a ticket for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add support for mounting volumes with mount trait [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez closed issue #5654: Add support for mounting volumes with mount trait
URL: https://github.com/apache/camel-k/issues/5654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org