You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/31 20:27:45 UTC

[GitHub] [arrow] emkornfield commented on a diff in pull request #14509: PARQUET-2204: [parquet-cpp] TypedColumnReaderImpl::Skip should reuse scratch space

emkornfield commented on code in PR #14509:
URL: https://github.com/apache/arrow/pull/14509#discussion_r1009841780


##########
cpp/src/parquet/column_reader.cc:
##########
@@ -928,6 +928,14 @@ class TypedColumnReaderImpl : public TypedColumnReader<DType>,
     this->exposed_encoding_ = encoding;
   }
 
+  // Allocate enough scratch space to accommodate skipping 16-bit levels or any
+  // value type for batch_size.
+  void InitScratchForSkip(int64_t batch_size);
+
+  // Scrtach space for reading and throwing away rep/def levels and values when

Review Comment:
   ```suggestion
     // Scratch space for reading and throwing away rep/def levels and values when
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org