You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/11/12 17:55:21 UTC
Review Request 40236: Check status of RS process for AMS in embedded
mode
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40236/
-----------------------------------------------------------
Review request for Ambari and Sid Wagle.
Bugs: AMBARI-13862
https://issues.apache.org/jira/browse/AMBARI-13862
Repository: ambari
Description
-------
TimelineMetricStoreWatcher added, it checks TimelineMetricStore functionality by adding and getting a fake metric to/from HBase.
Diffs
-----
ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-collector 0018bc2
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java d79ca68
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java aed5fed
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java be06650
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java fd51f3d
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcher.java PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcherTest.java PRE-CREATION
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml c73a401
Diff: https://reviews.apache.org/r/40236/diff/
Testing
-------
Unit tests passed
Thanks,
Dmytro Sen
Re: Review Request 40236: Check status of RS process for AMS in
embedded mode
Posted by Dmytro Sen <ds...@hortonworks.com>.
> On Ноя. 12, 2015, 7:31 п.п., Sid Wagle wrote:
> > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcher.java, line 110
> > <https://reviews.apache.org/r/40236/diff/1/?file=1124324#file1124324line110>
> >
> > Should there be a delay in put and get ?
> > Maybe this is not needed because of synchronous commit.
Yes, the commit is synchronous
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40236/#review106310
-----------------------------------------------------------
On Ноя. 12, 2015, 4:55 п.п., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40236/
> -----------------------------------------------------------
>
> (Updated Ноя. 12, 2015, 4:55 п.п.)
>
>
> Review request for Ambari and Sid Wagle.
>
>
> Bugs: AMBARI-13862
> https://issues.apache.org/jira/browse/AMBARI-13862
>
>
> Repository: ambari
>
>
> Description
> -------
>
> TimelineMetricStoreWatcher added, it checks TimelineMetricStore functionality by adding and getting a fake metric to/from HBase.
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-collector 0018bc2
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java d79ca68
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java aed5fed
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java be06650
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java fd51f3d
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcher.java PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcherTest.java PRE-CREATION
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml c73a401
>
> Diff: https://reviews.apache.org/r/40236/diff/
>
>
> Testing
> -------
>
> Unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 40236: Check status of RS process for AMS in
embedded mode
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40236/#review106310
-----------------------------------------------------------
ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-collector (line 174)
<https://reviews.apache.org/r/40236/#comment165046>
This is good, we do this manually as well so +1 for the change. Can we move this up with message "Stopping already running ams daemons, if any."
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java (line 151)
<https://reviews.apache.org/r/40236/#comment165047>
Valid, we should open a Jira for this.
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java (line 427)
<https://reviews.apache.org/r/40236/#comment165049>
Valid, we should open Phoenix Jira, maybe isValid() is a better use case.
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcher.java (line 110)
<https://reviews.apache.org/r/40236/#comment165050>
Should there be a delay in put and get ?
Maybe this is not needed because of synchronous commit.
- Sid Wagle
On Nov. 12, 2015, 4:55 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40236/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2015, 4:55 p.m.)
>
>
> Review request for Ambari and Sid Wagle.
>
>
> Bugs: AMBARI-13862
> https://issues.apache.org/jira/browse/AMBARI-13862
>
>
> Repository: ambari
>
>
> Description
> -------
>
> TimelineMetricStoreWatcher added, it checks TimelineMetricStore functionality by adding and getting a fake metric to/from HBase.
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-collector 0018bc2
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java d79ca68
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java aed5fed
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java be06650
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java fd51f3d
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcher.java PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcherTest.java PRE-CREATION
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml c73a401
>
> Diff: https://reviews.apache.org/r/40236/diff/
>
>
> Testing
> -------
>
> Unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 40236: Check status of RS process for AMS in
embedded mode
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40236/#review106454
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On Nov. 13, 2015, 3:28 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40236/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2015, 3:28 p.m.)
>
>
> Review request for Ambari and Sid Wagle.
>
>
> Bugs: AMBARI-13862
> https://issues.apache.org/jira/browse/AMBARI-13862
>
>
> Repository: ambari
>
>
> Description
> -------
>
> TimelineMetricStoreWatcher added, it checks TimelineMetricStore functionality by adding and getting a fake metric to/from HBase.
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-collector 0018bc2
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java d79ca68
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java aed5fed
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java be06650
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java fd51f3d
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcher.java PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcherTest.java PRE-CREATION
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml c73a401
>
> Diff: https://reviews.apache.org/r/40236/diff/
>
>
> Testing
> -------
>
> Unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 40236: Check status of RS process for AMS in
embedded mode
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40236/
-----------------------------------------------------------
(Updated Ноя. 13, 2015, 3:28 п.п.)
Review request for Ambari and Sid Wagle.
Bugs: AMBARI-13862
https://issues.apache.org/jira/browse/AMBARI-13862
Repository: ambari
Description
-------
TimelineMetricStoreWatcher added, it checks TimelineMetricStore functionality by adding and getting a fake metric to/from HBase.
Diffs (updated)
-----
ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-collector 0018bc2
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java d79ca68
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java aed5fed
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java be06650
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java fd51f3d
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcher.java PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcherTest.java PRE-CREATION
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml c73a401
Diff: https://reviews.apache.org/r/40236/diff/
Testing
-------
Unit tests passed
Thanks,
Dmytro Sen
Re: Review Request 40236: Check status of RS process for AMS in
embedded mode
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40236/
-----------------------------------------------------------
(Updated Ноя. 13, 2015, 3:27 п.п.)
Review request for Ambari and Sid Wagle.
Bugs: AMBARI-13862
https://issues.apache.org/jira/browse/AMBARI-13862
Repository: ambari
Description
-------
TimelineMetricStoreWatcher added, it checks TimelineMetricStore functionality by adding and getting a fake metric to/from HBase.
Diffs (updated)
-----
ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-collector 0018bc2
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java d79ca68
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java aed5fed
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java be06650
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java fd51f3d
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcher.java PRE-CREATION
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcherTest.java PRE-CREATION
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml c73a401
Diff: https://reviews.apache.org/r/40236/diff/
Testing
-------
Unit tests passed
Thanks,
Dmytro Sen