[GitHub] [iceberg] singhpk234 commented on a diff in pull request #5899: AWS: Add additional configurations for ApacheHttpClientBuilder

[GitBox <gi...@apache.org>]

singhpk234 commented on code in PR #5899:
URL: https://github.com/apache/iceberg/pull/5899#discussion_r985520324


##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -517,8 +599,15 @@ public class AwsProperties implements Serializable {
   public static final String LAKE_FORMATION_DB_NAME = "lakeformation.db-name";
 
   private String httpClientType;
+  private Long httpClientApacheConnectionAcquisitionTimeoutMS;
+  private Long httpClientApacheConnectionMaxIdleTimeMS;

Review Comment:
   [nit] either let's make everything suffix as `MS` or `Ms`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org