[GitHub] [iceberg] rdblue commented on a diff in pull request #5427: API/Core: Scan reporting result wrappers and parsers

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5427:
URL: https://github.com/apache/iceberg/pull/5427#discussion_r939730326


##########
api/src/main/java/org/apache/iceberg/metrics/ScanReport.java:
##########
@@ -19,28 +19,32 @@
 package org.apache.iceberg.metrics;
 
 import java.io.Serializable;
+import java.time.Duration;
 import java.util.concurrent.TimeUnit;
 import org.apache.iceberg.Schema;
 import org.apache.iceberg.expressions.Expression;
 import org.apache.iceberg.metrics.MetricsContext.Counter;
+import org.apache.iceberg.metrics.MetricsContext.Unit;
 import org.apache.iceberg.relocated.com.google.common.base.MoreObjects;
+import org.apache.iceberg.relocated.com.google.common.base.Objects;
 import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
 
 /** A Table Scan report that contains all relevant information from a Table Scan. */
 public class ScanReport implements Serializable {
 
   private final String tableName;
   private final long snapshotId;
-  private final Expression filter;
+  // TODO: change this to Expression once we have an ExpressionParser
+  private final String filter;

Review Comment:
   Can we omit this for now? If anything happens and we forget about it, I'd rather not make a breaking format change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org