[GitHub] [incubator-pinot] mcvsubbu commented on issue #7192: Flush Segments on a Schedule

[GitBox <gi...@apache.org>]

mcvsubbu commented on issue #7192:
URL: https://github.com/apache/incubator-pinot/issues/7192#issuecomment-885335818


   Please don't add controller API to flush segments.  It will lead to race conditions. Right now, servers drive the protocol, and let it be like that. If you desparately want to add a controller driven segment completion, then send a helix message to the participants and let them initiate the protocol, but I would like to make sure that this complexity is needed. 
   
   I agree with @mayankshriv that we need to re-look at the segment size first. Perhaps it is too big? @mapshen did you run the realtime provison helper? Can you cut/paste the output here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org