You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gora.apache.org by kamaci <gi...@git.apache.org> on 2015/09/11 00:03:36 UTC
[GitHub] gora pull request: GORA-439 Remove Unused Method Parameters
GitHub user kamaci opened a pull request:
https://github.com/apache/gora/pull/43
GORA-439 Remove Unused Method Parameters
Unused method parameters are removed and API signatures made clean.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kamaci/gora master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/gora/pull/43.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #43
----
commit 1f77291084e0a86b534aa354685ada246dbe7079
Author: Furkan KAMACI <fu...@gmail.com>
Date: 2015-09-10T22:02:06Z
Unused method parameters are removed and API signatures made clean.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-439 Remove Unused Method Parameters
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/gora/pull/43
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-439 Remove Unused Method Parameters
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the pull request:
https://github.com/apache/gora/pull/43#issuecomment-145281947
Hi @kamaci I had a look through the patch. Please make sure that there are no regressions. I am +1 to commit if this is the case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-439 Remove Unused Method Parameters
Posted by renato2099 <gi...@git.apache.org>.
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/43#issuecomment-151674809
Hey @kamaci I think I will try to respond to myself lol I think it is fine because the query object gets created by the dataStore, thus it will already contain a reference to it when passed into the MapReduce job. So I am a +1 after looking it more carefully
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-439 Remove Unused Method Parameters
Posted by renato2099 <gi...@git.apache.org>.
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/43#issuecomment-145287775
I am in favour of this, but yeah we might discuss about the API some more to see whether it makes sense to keep what. I mean right now, if those parameters are not being used, sure maybe we can take them out, but I think we should look into why they were put there e.g. passing the dataStore object into the GoraMapper, is this because we can get it through the Query object? I think most of the others are a lot more straight forward.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-439 Remove Unused Method Parameters
Posted by kamaci <gi...@git.apache.org>.
Github user kamaci commented on the pull request:
https://github.com/apache/gora/pull/43#issuecomment-145662887
Unused method parameters may lead a potential bug. Here is a list of what I've changed:
* CassandraSuperColumn.java#getUnionIndex(String fieldName, HColumn<ByteBuffer, ByteBuffer> uc)
* QueryCounter.java#createJob(DataStore<K,T> dataStore, Query<K,T> query)
* QueryCounter.java#countQuery(DataStore<K,T> dataStore, Query<K,T> query)
* WordCount.java#createJob(DataStore<String,WebPage> inStore, Query<String,WebPage> query, DataStore<String,TokenDatum> outStore)
* GoraInputFormat.java#setInputPath(PartitionQuery<K,T> partitionQuery, TaskAttemptContext context)
* GoraInputFormat.java#setInput(Job job, Query<K1,V1> query, DataStore<K1,V1> dataStore, boolean reuseObjects)
* GoraMapper.java#initMapperJob(Job job, Query<K1,V1> query, DataStore<K1,V1> dataStore, Class<K2> outKeyClass, Class<K2> outKeyClass, Class<V2> outValueClass, Class<? extends GoraMapper> mapperClass, Class<? extends Partitioner> partitionerClass, boolean reuseObjects)
* GoraMapper.java#initMapperJob(Job job, Query<K1,V1> query, DataStore<K1,V1> dataStore, Class<K2> outKeyClass, Class<K2> outKeyClass, Class<V2> outValueClass, Class<? extends GoraMapper> mapperClass, boolean reuseObjects)
* IOUtils.java#serialize(OutputStream os, SpecificDatumWriter<T> datumWriter, Schema schema, T object)
* IOUtils.java#serialize(SpecificDatumWriter<T> datumWriter, Schema schema, T object)
* IOUtils.java#deserialize(InputStream is, SpecificDatumReader<T> datumReader, Schema schema, T object)
* IOUtils.java#deserialize(byte[] bytes, SpecificDatumReader<T> datumReader, Schema schema, T object)
* DataStoreTestUtil.java#createEmployee(DataStore<K, Employee> dataStore)
* DataStoreTestUtil.java#createWebPage(DataStore<K, Employee> dataStore)
* DataStoreTestUtil.java#createBoss(DataStore<K, Employee> dataStore)
* MongoMapping.java#addClassField(String docNameFromMapping, String classFieldName, String docFieldName, String fieldType)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-439 Remove Unused Method Parameters
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the pull request:
https://github.com/apache/gora/pull/43#issuecomment-220396724
This has been merged right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-439 Remove Unused Method Parameters
Posted by kamaci <gi...@git.apache.org>.
Github user kamaci commented on the pull request:
https://github.com/apache/gora/pull/43#issuecomment-220437423
I thought something is wrong but it is completely OK, no problem. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---