[GitHub] spark pull request #9940: [SPARK-11955][SQL] Mark optional fields in merging...

[rxin <gi...@git.apache.org>]

Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9940#discussion_r69793308
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala ---
    @@ -359,6 +361,18 @@ object StructType extends AbstractDataType {
       protected[sql] def fromAttributes(attributes: Seq[Attribute]): StructType =
         StructType(attributes.map(a => StructField(a.name, a.dataType, a.nullable, a.metadata)))
     
    +  def removeMetadata(key: String, dt: DataType): DataType =
    +    dt match {
    +      case StructType(fields) =>
    +        val newFields = fields.map { f =>
    +          val mb = new MetadataBuilder()
    --- End diff --
    
    Unfortunately unless we have a timeline to actually fix the Parquet bug, I don't think we can expect the workaround will be removed in the near future. It's been almost half a year since the original patch is in, and the patch is still necessary.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org