You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/06/02 02:00:59 UTC

[GitHub] [rocketmq] caigy commented on a diff in pull request #4152: [#4151]Add option p to the updateGlobalWhiteAddr command.

caigy commented on code in PR #4152:
URL: https://github.com/apache/rocketmq/pull/4152#discussion_r886322028


##########
acl/src/main/java/org/apache/rocketmq/acl/plain/PlainPermissionManager.java:
##########
@@ -471,6 +471,10 @@ public boolean updateGlobalWhiteAddrsConfig(List<String> globalWhiteAddrsList) {
     }
 
     public boolean updateGlobalWhiteAddrsConfig(List<String> globalWhiteAddrsList, String fileName) {
+        if (fileName == null || fileName == "") {

Review Comment:
   use `equals()` instead of `==` for comparison



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org