You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/05/04 14:59:55 UTC

[GitHub] [cordova-plugin-device] RajanDhinoja opened a new pull request #96: Solved Samsung mobile device serial issue

RajanDhinoja opened a new pull request #96: Solved Samsung mobile device serial issue
URL: https://github.com/apache/cordova-plugin-device/pull/96
 
 
   ### Platforms affected
   Android
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   Few Samsung devices are not returning an actual result. I have added a few more method to get the device serial number so that the user can get their expected result. It can solve the below issue : 
   https://github.com/apache/cordova-plugin-device/issues/91
   
   ### Description
   <!-- Describe your changes in detail -->
   I have created a function that will solve the Samsung device serial issue as well other since I have added a few more cases according to their Manufacture and it's typed.
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   I have checked it in a few Samsung Android devices. Before this, it's not working properly but now I am getting the actual result.
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org