You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/05/12 05:41:16 UTC

[GitHub] [dolphinscheduler] zjw-zjw opened a new pull request #5449: [Fix]modify yarn.application.status.address

zjw-zjw opened a new pull request #5449:
URL: https://github.com/apache/dolphinscheduler/pull/5449


   <!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
   
   
   ## Purpose of the pull request
   
   <!--(For example: This pull request adds checkstyle plugin).-->
   
   ## Brief change log
   
   <!--*(for example:)*
     - *Add maven-checkstyle-plugin to root pom.xml*
   -->
   ## Verify this pull request
   
   <!--*(Please pick either of the following options)*-->
   
   This pull request is code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   <!--*(example:)*
     - *Added dolphinscheduler-dao tests for end-to-end.*
     - *Added CronUtilsTest to verify the change.*
     - *Manually verified the change by testing locally.* -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhuangchong commented on a change in pull request #5449: [Fix]modify yarn.application.status.address

Posted by GitBox <gi...@apache.org>.
zhuangchong commented on a change in pull request #5449:
URL: https://github.com/apache/dolphinscheduler/pull/5449#discussion_r630822571



##########
File path: dolphinscheduler-common/src/main/resources/common.properties
##########
@@ -58,7 +58,7 @@ fs.s3a.secret.key=OloCLq3n+8+sdPHUhJ21XrSxTC+JK
 yarn.resourcemanager.ha.rm.ids=192.168.xx.xx,192.168.xx.xx
 
 # if resourcemanager HA enable or not use resourcemanager, please keep the default value; If resourcemanager is single, you only need to replace ds1 to actual resourcemanager hostname.
-yarn.application.status.address=http://10.172.33.1:%s/ws/v1/cluster/apps/%s
+yarn.application.status.address=http://ds1:8088/ws/v1/cluster/apps/%s

Review comment:
       Thank you very much for your PR.
   The port value in the yarn application url 'yarn.application.status.address' is configured in the 'resource.manager.httpaddress.port' property, So here should be modified to 'yarn.application.status.address=http://ds1:%s/ws/v1/cluster/apps/%s'




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] chengshiwen closed pull request #5449: [Fix]modify yarn.application.status.address

Posted by GitBox <gi...@apache.org>.
chengshiwen closed pull request #5449:
URL: https://github.com/apache/dolphinscheduler/pull/5449


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] chengshiwen edited a comment on pull request #5449: [Fix]modify yarn.application.status.address

Posted by GitBox <gi...@apache.org>.
chengshiwen edited a comment on pull request #5449:
URL: https://github.com/apache/dolphinscheduler/pull/5449#issuecomment-839710727


   @zjw-zjw This problem has been fixed in #5393, and not just this one file and the one item. It's duplicated. So close it. Contributions are still welcome!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] chengshiwen commented on pull request #5449: [Fix]modify yarn.application.status.address

Posted by GitBox <gi...@apache.org>.
chengshiwen commented on pull request #5449:
URL: https://github.com/apache/dolphinscheduler/pull/5449#issuecomment-839710727


   @zjw-zjw This problem has been fixed in #5393, and not just this one file and the one item


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] chengshiwen edited a comment on pull request #5449: [Fix]modify yarn.application.status.address

Posted by GitBox <gi...@apache.org>.
chengshiwen edited a comment on pull request #5449:
URL: https://github.com/apache/dolphinscheduler/pull/5449#issuecomment-839710727


   @zjw-zjw This problem has been fixed in #5393, and not just this one file and the one item. It's duplicated


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org