You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/03 15:46:41 UTC
[jira] [Commented] (THRIFT-4164) Core in TSSLSocket cleanupOpenSSL
when destroying a mutex used by openssl
[ https://issues.apache.org/jira/browse/THRIFT-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15953686#comment-15953686 ]
ASF GitHub Bot commented on THRIFT-4164:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1235
THRIFT-4164: update openssl cleanup to match current requirements
Ran ctest -T MemCheck which runs all tests through valgrind and all passed. Manually inspected the TInterruptTest which includes TSSLInterruptTest and runs the initialize and cleanup methods running valgrind interactively and no issues (and no leaks).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift THRIFT-4164
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1235.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1235
----
commit aa18ccaaf472b06617a104f2cdbb9674e9c2bae5
Author: James E. King, III <ji...@simplivity.com>
Date: 2017-04-03T15:43:54Z
THRIFT-4164: update openssl cleanup to match current requirements
----
> Core in TSSLSocket cleanupOpenSSL when destroying a mutex used by openssl
> -------------------------------------------------------------------------
>
> Key: THRIFT-4164
> URL: https://issues.apache.org/jira/browse/THRIFT-4164
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.10.0
> Environment: Ubuntu 14.04, openssl (version TBD, I believe it is a 1.1.0 variant)
> Reporter: James E. King, III
> Assignee: James E. King, III
>
> In a project where thrift is used, i was investigating a core in an assertion in apache::thrift::concurrency::~Mutex (pthread variety). The mutex in question was one of the locking mutexes that thrift gives to openssl. The core occurred in TSSLSocket::cleanupOpenSSL() where the mutexes are destroyed (on the last line).
> I suspect that we might be changing the locking callbacks too early in the cleanup process; perhaps one of the other cleanup calls that follows it would have released a mutex in some situations? In any case, this needs to be investigated and I am assigning it to myself.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)