[jira] [Commented] (METRON-1476) Update angular

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/METRON-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533843#comment-16533843 ] 

ASF GitHub Bot commented on METRON-1476:
----------------------------------------

GitHub user sardell opened a pull request:

    https://github.com/apache/metron/pull/1096

    METRON-1476: Update Angular in Alerts UI

    ## Contributor Comments
    This PR updates the Alerts UI to use the latest stable release of Angular (6.0.6). The original ticket in the ASF JIRA was originally intended to update both the Alerts and Config UI. However, I did not update Config UI due to there being a lack of e2e and unit tests. Without those, it's very hard to be confident that the update didn't break any functionality.
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
    - [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [ ] Have you included steps or a guide to how the change may be verified and tested manually?
    - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
      ```
    
    - [ ] Have you written or updated unit tests and or integration tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sardell/metron METRON-1476

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/1096.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1096
    
----
commit b5788fb1f892012d4cd105fc8c23667fd7c8df6f
Author: Shane Ardell <sa...@...>
Date:   2018-06-27T13:08:01Z

    update angular to current stable version

commit 4f1ee4fea99cc154ee0a328a349abab58c0d67a2
Author: Shane Ardell <sa...@...>
Date:   2018-07-05T10:45:58Z

    remove module file extension

commit cd5942a11c25e8ccb1be98919e3c4883823f2f59
Author: Shane Ardell <sa...@...>
Date:   2018-07-05T11:09:53Z

    add http interceptor for default headers

commit fa40b49f9a6d2aa4b36a9266e4b72b28a5c26ecb
Author: Shane Ardell <sa...@...>
Date:   2018-07-05T12:01:16Z

    update configurations

commit 86bfaa30c89b24474fbfaed118c3b35c483c19e3
Author: Shane Ardell <sa...@...>
Date:   2018-07-05T12:02:21Z

    update dependencies

commit 1abd618b5f2b53381feb23ba12ccb1fa282da297
Author: Shane Ardell <sa...@...>
Date:   2018-07-05T12:03:06Z

    update services to use HttpClient and rxjs changes

commit c7e7c95fd84618218b786d8f8ecad3d660434318
Author: Shane Ardell <sa...@...>
Date:   2018-07-05T15:50:24Z

    merge master and resolve conflicts in view and login specs

----


> Update angular
> --------------
>
>                 Key: METRON-1476
>                 URL: https://issues.apache.org/jira/browse/METRON-1476
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Daniel Toth
>            Assignee: Daniel Toth
>            Priority: Major
>
> Update angular to speed up development



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)