You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shiro.apache.org by GitBox <gi...@apache.org> on 2021/07/06 19:39:42 UTC

[GitHub] [shiro] zAlbee opened a new pull request #309: [SHIRO-825] Fixes "IllegalArgumentException: There is no configured chain under the name/key"

zAlbee opened a new pull request #309:
URL: https://github.com/apache/shiro/pull/309


   Fixes https://issues.apache.org/jira/browse/SHIRO-825: Trailing slash in URI results in "IllegalArgumentException: There is no configured chain under the name/key"
   
   When the request URI has a trailing slash, but the pattern does not have a trailing slash (or vice versa), it is still supposed to match. However, when they don't match exactly, we enter the `else` branch where the call to `filterChainManager.proxy()` has the incorrect parameter! (When they match exactly, the call to `filterChainManager.proxy()` has the correct parameter -- see line 114).
   
   This seems to be a copy/paste error introduced by commit https://github.com/apache/shiro/commit/ab1ea4a2006f6bd6a2b5f72740b7135662f8f160#diff-a724e4e5fde47ea6cc29803d5a4581a299b74f09d4ec5ce047e7d3e056116815R129
   
   In Shiro 1.7.0, it didn't have this duplicate code, and it was working correctly.
   
   ---------
   
   Following this checklist to help us incorporate your contribution quickly and easily:
   
    - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SHIRO) filed 
          for the change (usually before you start working on it).  Trivial changes like typos do not 
          require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [x] Each commit in the pull request should have a meaningful subject line and body.
    - [x] Format the pull request title like `[SHIRO-XXX] - Fixes bug in SessionManager`,
          where you replace `SHIRO-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the commit message.
    - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. 
    
   Trivial changes like typos do not require a JIRA issue (javadoc, comments...). 
   In this case, just format the pull request title like `(DOC) - Add javadoc in SessionManager`.
    
   If this is your first contribution, you have to read the [Contribution Guidelines](https://github.com/apache/shiro/blob/master/CONTRIBUTING.md)
   
   If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) 
   if you are unsure please ask on the developers list.
   
   To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shiro] bmarwell merged pull request #309: [SHIRO-825] Fixes "IllegalArgumentException: There is no configured chain under the name/key"

Posted by GitBox <gi...@apache.org>.
bmarwell merged pull request #309:
URL: https://github.com/apache/shiro/pull/309


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shiro] zAlbee commented on a change in pull request #309: [SHIRO-825] Fixes "IllegalArgumentException: There is no configured chain under the name/key"

Posted by GitBox <gi...@apache.org>.
zAlbee commented on a change in pull request #309:
URL: https://github.com/apache/shiro/pull/309#discussion_r665461423



##########
File path: web/src/test/java/org/apache/shiro/web/filter/mgt/PathMatchingFilterChainResolverTest.java
##########
@@ -255,4 +255,44 @@ public void testMultipleChainsPathEndsWithSlash() {
         FilterChain resolved = resolver.getChain(request, response, chain);
         assertThat(resolved, notNullValue());
     }
+
+    /**
+     * Test asserting <a href="https://issues.apache.org/jira/browse/SHIRO-825">SHIRO-825<a/>.
+     */
+    @Test
+    public void testGetChainWhenPathEndsWithSlash() {

Review comment:
       I verified that this test passes in Shiro 1.7.0 and fails in 1.7.1 (without the fix). Thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shiro] zAlbee commented on pull request #309: [SHIRO-825] Fixes "IllegalArgumentException: There is no configured chain under the name/key"

Posted by GitBox <gi...@apache.org>.
zAlbee commented on pull request #309:
URL: https://github.com/apache/shiro/pull/309#issuecomment-876715019


   Is there anything else I need to do to get this merged? (I noticed some failing checks). We saw that 1.7.1 fixed some vulnerabilities and would like to upgrade to a fixed version of that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shiro] bdemers commented on pull request #309: [SHIRO-825] Fixes "IllegalArgumentException: There is no configured chain under the name/key"

Posted by GitBox <gi...@apache.org>.
bdemers commented on pull request #309:
URL: https://github.com/apache/shiro/pull/309#issuecomment-875042581


   Thanks @zAlbee!
   
   We need a test case for this, I can add it, but I have a few follow up questions I'll post in SHIRO-825


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shiro] bdemers commented on pull request #309: [SHIRO-825] Fixes "IllegalArgumentException: There is no configured chain under the name/key"

Posted by GitBox <gi...@apache.org>.
bdemers commented on pull request #309:
URL: https://github.com/apache/shiro/pull/309#issuecomment-875065116


   Test added :)
   
   We need to backport this fix to 1.x, once this gets another set of eyes, I can backport it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shiro] bmarwell commented on pull request #309: [SHIRO-825] Fixes "IllegalArgumentException: There is no configured chain under the name/key"

Posted by GitBox <gi...@apache.org>.
bmarwell commented on pull request #309:
URL: https://github.com/apache/shiro/pull/309#issuecomment-876920165


   > Is there anything else I need to do to get this merged? 
   
   Yes:
   
   > We need to backport this fix to 1.x, once this gets another set of eyes, I can backport it
   
   @bdemers I can work on a backport next week. If you like, you can go ahead and merge it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org