You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2022/01/22 17:25:42 UTC

[GitHub] [incubator-brpc] lorinlee commented on a change in pull request #1653: Fix unstable bthread_unittest.cpp case

lorinlee commented on a change in pull request #1653:
URL: https://github.com/apache/incubator-brpc/pull/1653#discussion_r790163841



##########
File path: test/bthread_unittest.cpp
##########
@@ -294,7 +294,7 @@ TEST_F(BthreadTest, small_threads) {
         for (size_t j = 0; j < 3; ++j) {
             th.clear();
             if (j == 1) {

Review comment:
       if是不是也可以删掉呀。另外不需要的代码是不是可以就直接删掉,不留这类的注释了,改动记录在git log里有




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org