You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/10/22 17:05:15 UTC

[GitHub] [hadoop] steveloughran commented on issue #1664: HADOOP-16658 - S3A connector does not support including the token ren…

steveloughran commented on issue #1664: HADOOP-16658 - S3A connector does not support including the token ren…
URL: https://github.com/apache/hadoop/pull/1664#issuecomment-545060086
 
 
   Code LGTM; some minor comments about tests
   
   I'd like AbstractS3ATokenIdentifier to create a Text() if a null renewer was passed in; this is consistent with the existing code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org