You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/06/18 07:50:49 UTC
Review Request 35593: LENS-616 : Altering table should not remove
existing properties
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35593/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-616
https://issues.apache.org/jira/browse/LENS-616
Repository: lens
Description
-------
Fixed getTable from StorageTableDesc to initialize table with existing table, if any.
- Add regression test which fails without the patch.
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java d3c9974
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java d481f93
Diff: https://reviews.apache.org/r/35593/diff/
Testing
-------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 35593: LENS-616 : Altering table should not remove
existing properties
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35593/#review88337
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On June 18, 2015, 11:20 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35593/
> -----------------------------------------------------------
>
> (Updated June 18, 2015, 11:20 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-616
> https://issues.apache.org/jira/browse/LENS-616
>
>
> Repository: lens
>
>
> Description
> -------
>
> Fixed getTable from StorageTableDesc to initialize table with existing table, if any.
>
> - Add regression test which fails without the patch.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java d3c9974
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java d481f93
>
> Diff: https://reviews.apache.org/r/35593/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 35593: LENS-616 : Altering table should not remove
existing properties
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35593/
-----------------------------------------------------------
(Updated June 18, 2015, 6:11 a.m.)
Review request for lens.
Bugs: LENS-616
https://issues.apache.org/jira/browse/LENS-616
Repository: lens
Description
-------
Fixed getTable from StorageTableDesc to initialize table with existing table, if any.
- Add regression test which fails without the patch.
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java d3c9974
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java d481f93
Diff: https://reviews.apache.org/r/35593/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.495s]
[INFO] Lens .............................................. SUCCESS [3.339s]
[INFO] Lens API .......................................... SUCCESS [23.197s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.250s]
[INFO] Lens Cube ......................................... SUCCESS [3:31.632s]
[INFO] Lens DB storage ................................... SUCCESS [22.838s]
[INFO] Lens Query Library ................................ SUCCESS [15.726s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:53.722s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [33.719s]
[INFO] Lens Server ....................................... SUCCESS [5:34.607s]
[INFO] Lens client ....................................... SUCCESS [36.120s]
[INFO] Lens CLI .......................................... SUCCESS [3:32.340s]
[INFO] Lens Examples ..................................... SUCCESS [8.915s]
[INFO] Lens Distribution ................................. SUCCESS [8.496s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:26.066s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.119s]
[INFO] Lens Regression ................................... SUCCESS [10.863s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20:07.386s
[INFO] Finished at: Thu Jun 18 06:07:32 UTC 2015
[INFO] Final Memory: 173M/1367M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 35593: LENS-616 : Altering table should not remove
existing properties
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35593/#review88338
-----------------------------------------------------------
Ship it!
Ship It!
- Jaideep dhok
On June 18, 2015, 5:50 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35593/
> -----------------------------------------------------------
>
> (Updated June 18, 2015, 5:50 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-616
> https://issues.apache.org/jira/browse/LENS-616
>
>
> Repository: lens
>
>
> Description
> -------
>
> Fixed getTable from StorageTableDesc to initialize table with existing table, if any.
>
> - Add regression test which fails without the patch.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java d3c9974
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java d481f93
>
> Diff: https://reviews.apache.org/r/35593/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>