You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2023/01/16 19:27:36 UTC
[GitHub] [netbeans] matthiasblaesing opened a new pull request, #5301: Jakarta EE 10 - Platform/API/RI support
matthiasblaesing opened a new pull request, #5301:
URL: https://github.com/apache/netbeans/pull/5301
This PR was created on the basis of https://github.com/apache/netbeans/pull/4692
The changes from that PR were rebased onto master and then squashed as far as it seemed reasonable. To check the valid rebase without changing the code, this was done:
```bash
git checkout -b pr-4692-ref master
git merge github/pr/4692
git checkout -b pr-4692 github/pr/4692
git rebase master
# + multiple squash rounds
git diff pr-4692-ref..pr-4692
```
results in
```diff
diff --git a/enterprise/websvc.restapi/nbproject/org-netbeans-modules-websvc-restapi.sig b/enterprise/websvc.restapi/nbproject/org-netbeans-modules-websvc-restapi.sig
index 9f7f657d6276..60e477dcc2d0 100644
--- a/enterprise/websvc.restapi/nbproject/org-netbeans-modules-websvc-restapi.sig
+++ b/enterprise/websvc.restapi/nbproject/org-netbeans-modules-websvc-restapi.sig
@@ -1,5 +1,5 @@
#Signature file v4.1
-#Version 1.54
+#Version 1.55
CLSS public abstract interface java.io.Serializable
diff --git a/nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ignored-overlaps b/nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ignored-overlaps
index 1f39e97a714e..5673dc068035 100644
--- a/nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ignored-overlaps
+++ b/nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ignored-overlaps
@@ -123,4 +123,4 @@ platform/o.apache.commons.lang3/external/commons-lang3-3.8.1.jar java/maven.embe
ide/db.metadata.model/external/mysql-connector-j-8.0.31.jar ide/db.mysql/external/mysql-connector-j-8.0.31.jar
# Jakarta EE API doc is repackaged to align with old NetBeans format, embedded indexes are thus identically and can be ignored.
-enterprise/jakartaee10.platform/external/generated-jakarta.jakartaee-api-10.0.0-javadoc.jar enterprise/jakartaee10.platform/external/jakarta.jakartaee-api-10.0.0-javadoc.jar
\ No newline at end of file
+enterprise/jakartaee10.platform/external/generated-jakarta.jakartaee-api-10.0.0-javadoc.jar enterprise/jakartaee10.platform/external/jakarta.jakartaee-api-10.0.0-javadoc.jar
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #5301: Jakarta EE 10 - Platform/API/RI support
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #5301:
URL: https://github.com/apache/netbeans/pull/5301#issuecomment-1385720615
Closing - I'll comment in the original PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #5301: Jakarta EE 10 - Platform/API/RI support
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #5301:
URL: https://github.com/apache/netbeans/pull/5301#issuecomment-1385741726
Sorry for the confusion - @pepness I'm just building with your changes and push here to get testing and will review in parallel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] pepness commented on a diff in pull request #5301: Jakarta EE 10 - Platform/API/RI support
Posted by GitBox <gi...@apache.org>.
pepness commented on code in PR #5301:
URL: https://github.com/apache/netbeans/pull/5301#discussion_r1071633571
##########
enterprise/glassfish.tooling/src/org/netbeans/modules/glassfish/tooling/server/config/GlassFishV7_0_0.xml:
##########
@@ -0,0 +1,93 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<server>
+ <tools lib="lib">
+ <asadmin jar="client/appserver-cli.jar"/>
+ </tools>
+ <java version="18">
+ <platform version="11"/>
+ <platform version="12"/>
+ <platform version="13"/>
+ <platform version="14"/>
+ <platform version="15"/>
+ <platform version="16"/>
+ <platform version="17"/>
+ <platform version="18"/>
+ </java>
+ <javaee version="10.0.0">
+ <profile version="10.0.0" type="web"/>
+ <profile version="10.0.0" type="full" check="full"/>
+ <module type="war"/>
+ <module type="car" check="full"/>
+ <module type="ear" check="full"/>
+ <module type="ejb" check="full"/>
+ <module type="rar" check="full"/>
+ <check name="full">
+ <file path="appclient-server-core.jar"/>
+ </check>
+ </javaee>
+ <library id="Java EE">
+ <classpath>
+ <fileset dir="modules">
+ <include name="jakarta\..+\.jar"/>
+ <include name="jakarta.enterprise.cdi-api.jar"/>
+ <include name="jakarta.validation-api.jar"/>
+ <include name="jaxb-osgi.jar"/>
+ <include name="webservices-osgi.jar"/>
+ <include name="weld-osgi-bundle.jar"/>
+ </fileset>
+ <fileset dir="modules/endorsed">
+ <include name=".+\.jar"/>
+ </fileset>
+ </classpath>
+ <javadocs>
+ <lookup path="docs/jakartaee10-doc-api.jar"/>
+ </javadocs>
+ <sources>
+ </sources>
+ </library>
+ <library id="Jersey 3">
+ <classpath>
+ <fileset dir="modules">
+ <include name="jackson.+\.jar"/>
+ <include name="jersey.+\.jar"/>
+ <include name="jettison.*\.jar"/>
+ </fileset>
+ </classpath>
+ <javadocs>
+ <link url="https://repo1.maven.org/maven2/org/glassfish/jersey/jersey-documentation/3.0.8/jersey-documentation-3.0.8-docbook.zip"/>
Review Comment:
Jersey 3.0.x is for Jakarta EE 9, the url for Jakarta EE 10 is:
https://repo1.maven.org/maven2/org/glassfish/jersey/jersey-documentation/3.1.0/jersey-documentation-3.1.0-docbook.zip
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing closed pull request #5301: Jakarta EE 10 - Platform/API/RI support
Posted by GitBox <gi...@apache.org>.
matthiasblaesing closed pull request #5301: Jakarta EE 10 - Platform/API/RI support
URL: https://github.com/apache/netbeans/pull/5301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] pepness commented on pull request #5301: Jakarta EE 10 - Platform/API/RI support
Posted by GitBox <gi...@apache.org>.
pepness commented on PR #5301:
URL: https://github.com/apache/netbeans/pull/5301#issuecomment-1384913319
Hi @matthiasblaesing, I made a [branch](https://github.com/pepness/incubator-netbeans/tree/pr-4692-ref) with some fixes and improvements like adding support for javadoc jars that only have the element-list file instead of the package-list file like is the case with the jakartaee-10 javadoc jar, without this the javadoc is not accessible within the IDE. I create a PR to your branch but it has some newer PR that are already in master because I rebase it with my master, sorry for the mess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #5301: Jakarta EE 10 - Platform/API/RI support
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #5301:
URL: https://github.com/apache/netbeans/pull/5301#issuecomment-1385926547
Closing - force push to #4692 worked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing closed pull request #5301: Jakarta EE 10 - Platform/API/RI support
Posted by GitBox <gi...@apache.org>.
matthiasblaesing closed pull request #5301: Jakarta EE 10 - Platform/API/RI support
URL: https://github.com/apache/netbeans/pull/5301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] pepness commented on a diff in pull request #5301: Jakarta EE 10 - Platform/API/RI support
Posted by GitBox <gi...@apache.org>.
pepness commented on code in PR #5301:
URL: https://github.com/apache/netbeans/pull/5301#discussion_r1071633571
##########
enterprise/glassfish.tooling/src/org/netbeans/modules/glassfish/tooling/server/config/GlassFishV7_0_0.xml:
##########
@@ -0,0 +1,93 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<server>
+ <tools lib="lib">
+ <asadmin jar="client/appserver-cli.jar"/>
+ </tools>
+ <java version="18">
+ <platform version="11"/>
+ <platform version="12"/>
+ <platform version="13"/>
+ <platform version="14"/>
+ <platform version="15"/>
+ <platform version="16"/>
+ <platform version="17"/>
+ <platform version="18"/>
+ </java>
+ <javaee version="10.0.0">
+ <profile version="10.0.0" type="web"/>
+ <profile version="10.0.0" type="full" check="full"/>
+ <module type="war"/>
+ <module type="car" check="full"/>
+ <module type="ear" check="full"/>
+ <module type="ejb" check="full"/>
+ <module type="rar" check="full"/>
+ <check name="full">
+ <file path="appclient-server-core.jar"/>
+ </check>
+ </javaee>
+ <library id="Java EE">
+ <classpath>
+ <fileset dir="modules">
+ <include name="jakarta\..+\.jar"/>
+ <include name="jakarta.enterprise.cdi-api.jar"/>
+ <include name="jakarta.validation-api.jar"/>
+ <include name="jaxb-osgi.jar"/>
+ <include name="webservices-osgi.jar"/>
+ <include name="weld-osgi-bundle.jar"/>
+ </fileset>
+ <fileset dir="modules/endorsed">
+ <include name=".+\.jar"/>
+ </fileset>
+ </classpath>
+ <javadocs>
+ <lookup path="docs/jakartaee10-doc-api.jar"/>
+ </javadocs>
+ <sources>
+ </sources>
+ </library>
+ <library id="Jersey 3">
+ <classpath>
+ <fileset dir="modules">
+ <include name="jackson.+\.jar"/>
+ <include name="jersey.+\.jar"/>
+ <include name="jettison.*\.jar"/>
+ </fileset>
+ </classpath>
+ <javadocs>
+ <link url="https://repo1.maven.org/maven2/org/glassfish/jersey/jersey-documentation/3.0.8/jersey-documentation-3.0.8-docbook.zip"/>
Review Comment:
Jersey 3.0.x is for Jakarta EE 9, the url for Jakarta EE 10 is:
https://repo1.maven.org/maven2/org/glassfish/jersey/jersey-documentation/3.1.0/jersey-documentation-3.1.0-docbook.zip
##########
enterprise/glassfish.tooling/src/org/netbeans/modules/glassfish/tooling/server/config/GlassFishV7_0_0.xml:
##########
@@ -0,0 +1,93 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<server>
+ <tools lib="lib">
+ <asadmin jar="client/appserver-cli.jar"/>
+ </tools>
+ <java version="18">
Review Comment:
It supports up to version 19
[Release 7](https://github.com/eclipse-ee4j/glassfish/releases/tag/7.0.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] pepness commented on a diff in pull request #5301: Jakarta EE 10 - Platform/API/RI support
Posted by GitBox <gi...@apache.org>.
pepness commented on code in PR #5301:
URL: https://github.com/apache/netbeans/pull/5301#discussion_r1071633661
##########
enterprise/glassfish.tooling/src/org/netbeans/modules/glassfish/tooling/server/config/GlassFishV7_0_0.xml:
##########
@@ -0,0 +1,93 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<server>
+ <tools lib="lib">
+ <asadmin jar="client/appserver-cli.jar"/>
+ </tools>
+ <java version="18">
Review Comment:
It supports up to version 19
[Release 7](https://github.com/eclipse-ee4j/glassfish/releases/tag/7.0.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists