[GitHub] [incubator-opendal] Ji-Xinyou commented on a diff in pull request #2260: feat(core): Add trait and public API for `append`

["Ji-Xinyou (via GitHub)" <gi...@apache.org>]

Ji-Xinyou commented on code in PR #2260:
URL: https://github.com/apache/incubator-opendal/pull/2260#discussion_r1193012377


##########
core/src/raw/oio/write.rs:
##########
@@ -178,3 +180,87 @@ impl<T: BlockingWrite + ?Sized> BlockingWrite for Box<T> {
         (**self).close()
     }
 }
+
+/// AppendOperation is the name for APIs of Append.
+#[derive(Debug, Copy, Clone, Hash, Eq, PartialEq)]
+#[non_exhaustive]
+pub enum AppendOperation {

Review Comment:
   Seems from the implementation level, append is parallel with write. I think separate this into a new file makes more sense.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org