[jira] Commented: (JCR-741) Handling of multiple residual prop defs in EffectiveNodeTypeImpl

["Julian Reschke (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCR-741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474224 ] 

Julian Reschke commented on JCR-741:
------------------------------------

Fixing this properly requires several changes.

(1) Do not consider multiple residual prop defs when they differ in their OnParentVersionAction value,

(2) Rewrite the transient layer so that in presence of multiple residuals it will pick the "right" one (such as for Property.getDefinition()).

As (1) is simple and allows my SPI stack to continue to work for now, I'll fix that right away.

For (2), I'd recommend to change getMatchingPropDef () as below:

- only one method
- each of the definition's aspects can be marked as "don't care" (by changing int->Integer, boolean->Boolean and allowing null values here).

Feedback appreciated.


> Handling of multiple residual prop defs in EffectiveNodeTypeImpl
> ----------------------------------------------------------------
>
>                 Key: JCR-741
>                 URL: https://issues.apache.org/jira/browse/JCR-741
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: SPI
>            Reporter: Julian Reschke
>         Assigned To: Julian Reschke
>            Priority: Minor
>
> org.apache.jackrabbit.jcr2spi.nodetype.EffectiveNodeTypeImpl currently rejects multiple residual property definitions, if they do not differ in getMultiple(). In fact, it should accept all combinations, so differing values for getOnParentVersionAction and other aspects should be accepted as well.
> See JSR 170, 6.7.8:
> "For purposes of the above, the notion of two definitions having the same name does not apply to two residual definitions. Two (or more) residual property or child node definitions with differing subattributes must be permitted to co-exist in the same effective node type. They are interpreted as disjunctive (ORed) options."

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.