You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by lulf <gi...@git.apache.org> on 2016/11/18 08:53:45 UTC
[GitHub] qpid-proton pull request #90: PROTON-1355: Set ssl.peer_hostname to virtual_...
GitHub user lulf opened a pull request:
https://github.com/apache/qpid-proton/pull/90
PROTON-1355: Set ssl.peer_hostname to virtual_host if specified
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lulf/qpid-proton PROTON-1355
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-proton/pull/90.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #90
----
commit d49ab3f96082a29489d2f1fc8880590d74338f68
Author: Ulf Lilleengen <lu...@redhat.com>
Date: 2016-11-18T08:52:02Z
PROTON-1355: Set ssl.peer_hostname to virtual_host if specified
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton pull request #90: PROTON-1355: Set ssl.peer_hostname to virtual_...
Posted by astitcher <gi...@git.apache.org>.
Github user astitcher commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/90#discussion_r88679501
--- Diff: proton-c/bindings/python/proton/reactor.py ---
@@ -565,7 +565,7 @@ def _connect(self, connection, reactor):
if not self.ssl_domain:
raise SSLUnavailable("amqps: SSL libraries not found")
self.ssl = SSL(transport, self.ssl_domain)
- self.ssl.peer_hostname = url.host
+ self.ssl.peer_hostname = self.virtual_host if self.virtual_host != None else url.host
--- End diff --
actually you can write it even more clearly ...
... = self.virtual_host or url.host
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton pull request #90: PROTON-1355: Set ssl.peer_hostname to virtual_...
Posted by lulf <gi...@git.apache.org>.
Github user lulf commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/90#discussion_r88675979
--- Diff: proton-c/bindings/python/proton/reactor.py ---
@@ -565,7 +565,7 @@ def _connect(self, connection, reactor):
if not self.ssl_domain:
raise SSLUnavailable("amqps: SSL libraries not found")
self.ssl = SSL(transport, self.ssl_domain)
- self.ssl.peer_hostname = url.host
+ self.ssl.peer_hostname = self.virtual_host if self.virtual_host != None else url.host
--- End diff --
Agreed. I chose to write it this way to be consistent with the rest of the code which seems to explicitly check for None.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton pull request #90: PROTON-1355: Set ssl.peer_hostname to virtual_...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/qpid-proton/pull/90
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org