You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/05 11:57:34 UTC
[GitHub] [spark-website] MaxGekk commented on a change in pull request #330: Document benchmark GitHub Actions workflow, and update contribution guide
MaxGekk commented on a change in pull request #330:
URL: https://github.com/apache/spark-website/pull/330#discussion_r607051876
##########
File path: site/developer-tools.html
##########
@@ -394,27 +394,51 @@ <h4>Testing K8S</h4>
<p>Kubernetes, and more importantly, minikube have rapid release cycles, and point releases have been found to be buggy and/or break older and existing functionality. If you are having trouble getting tests to pass on Jenkins, but locally things work, don’t hesitate to file a Jira issue.</p>
-<h3>Running tests in your forked repository using GitHub Actions</h3>
+<h3>Testing with GitHub Actions workflow</h3>
-<p>GitHub Actions is a functionality within GitHub that enables continuous integration and a wide range of automation.
-We already have started using some action scripts and one of them is to run tests for <a href="https://spark.apache.org/contributing.html">pull requests</a>.
-If you are planning to create a new pull request, it is important to check if tests can pass on your branch before creating a pull request.
-This is because our GitHub Acrions script automatically runs tests for your pull request/following commits and
-this can burden our limited resources of GitHub Actions.</p>
+<p>Apache Spark leverages GitHub Actions that enables continuous integration and a wide range of automation. Apache Spark repository provides several GitHub Actions workflows for developers to run before creating a pull request.</p>
Review comment:
enables -> enable
##########
File path: developer-tools.md
##########
@@ -216,25 +216,45 @@ In case of a failure the POD logs (driver and executors) can be found at the end
Kubernetes, and more importantly, minikube have rapid release cycles, and point releases have been found to be buggy and/or break older and existing functionality. If you are having trouble getting tests to pass on Jenkins, but locally things work, don't hesitate to file a Jira issue.
-<h3>Running tests in your forked repository using GitHub Actions</h3>
+<h3>Testing with GitHub Actions workflow</h3>
-GitHub Actions is a functionality within GitHub that enables continuous integration and a wide range of automation.
-We already have started using some action scripts and one of them is to run tests for [pull requests](https://spark.apache.org/contributing.html).
-If you are planning to create a new pull request, it is important to check if tests can pass on your branch before creating a pull request.
-This is because our GitHub Acrions script automatically runs tests for your pull request/following commits and
-this can burden our limited resources of GitHub Actions.
+Apache Spark leverages GitHub Actions that enables continuous integration and a wide range of automation. Apache Spark repository provides several GitHub Actions workflows for developers to run before creating a pull request.
Review comment:
enables -> enable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org