You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2018/12/20 16:40:25 UTC
Review Request 69612: Refactored parallel test runner.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69612/
-----------------------------------------------------------
Review request for mesos, Armand Grillet and Benjamin Bannier.
Repository: mesos
Description
-------
See summary.
Diffs
-----
support/mesos-gtest-runner.py 88a60c39e32730cd2875dc97c2d85cc314255050
Diff: https://reviews.apache.org/r/69612/diff/1/
Testing
-------
make check
sudo make check
Thanks,
Andrei Budnik
Re: Review Request 69612: Refactored parallel test runner.
Posted by Andrei Budnik <ab...@mesosphere.com>.
> On Jan. 16, 2019, 2:02 p.m., Benjamin Bannier wrote:
> > support/mesos-gtest-runner.py
> > Line 246 (original)
> > <https://reviews.apache.org/r/69612/diff/1/?file=2115315#file2115315line247>
> >
> > Any reason to not preserve the path normalization here?
`EXECUTABLE` class variable is initialized with `abspath` and passed to `options_gen` as an argument.
I think it's the caller's duty to ensure that the path is absolute.
- Andrei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69612/#review212068
-----------------------------------------------------------
On Dec. 20, 2018, 4:40 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69612/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2018, 4:40 p.m.)
>
>
> Review request for mesos, Armand Grillet and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> support/mesos-gtest-runner.py 88a60c39e32730cd2875dc97c2d85cc314255050
>
>
> Diff: https://reviews.apache.org/r/69612/diff/2/
>
>
> Testing
> -------
>
> make check
> sudo make check
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 69612: Refactored parallel test runner.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69612/#review212068
-----------------------------------------------------------
Fix it, then Ship it!
Thanks for the cleanup, Andrei!
support/mesos-gtest-runner.py
Line 246 (original)
<https://reviews.apache.org/r/69612/#comment297678>
Any reason to not preserve the path normalization here?
support/mesos-gtest-runner.py
Line 282 (original), 280 (patched)
<https://reviews.apache.org/r/69612/#comment297679>
We could take this a step further by taking advantage of implicit bool to integer conversions,
NFAILED = sum(not success, for success, _ in RESULTS)
- Benjamin Bannier
On Dec. 20, 2018, 5:40 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69612/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2018, 5:40 p.m.)
>
>
> Review request for mesos, Armand Grillet and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> support/mesos-gtest-runner.py 88a60c39e32730cd2875dc97c2d85cc314255050
>
>
> Diff: https://reviews.apache.org/r/69612/diff/1/
>
>
> Testing
> -------
>
> make check
> sudo make check
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 69612: Refactored parallel test runner.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69612/#review212072
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['69612']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2791/mesos-review-69612
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2791/mesos-review-69612/logs/mesos-tests.log):
```
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_Default_CMD
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_Default_CMD_Override
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_Default_CMD_Args
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_SlaveRecoveryTaskContainer
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhileFetching
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS
[ FAILED ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull
28 FAILED TESTS
YOU HAVE 231 DISABLED TESTS
3 from RUNNING to DESTROYING
I0116 15:11:14.373539 15168 launcher.cpp:161] Asked to destroy container e9ac3179-3a19-410d-9141-d0064309e313
W0116 15:11:14.374548 18324 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=6208 to peer '192.10.1.6:49859': IO failed with error code: The specified network name is no longer available.
W0116 15:11:14.375532 18324 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=9068 to peer '192.10.1.6:49860': IO failed with error code: The specified network name is no longer available.
I0116 15:11:14.459478 27384 containerizer.cpp:2975] Container e9ac3179-3a19-410d-9141-d0064309e313 has exited
I0116 15:11:14.488662 26908 master.cpp:1109] Master terminating
I0116 15:11:14.490479 22140 hierarchical.cpp:644] Removed agent a1313f56-2a59-49b4-a47e-fc3fa39da70c-S0
I0116 15:11:14.985491 18324 process.cpp:927] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Dec. 20, 2018, 4:40 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69612/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2018, 4:40 p.m.)
>
>
> Review request for mesos, Armand Grillet and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> support/mesos-gtest-runner.py 88a60c39e32730cd2875dc97c2d85cc314255050
>
>
> Diff: https://reviews.apache.org/r/69612/diff/2/
>
>
> Testing
> -------
>
> make check
> sudo make check
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 69612: Refactored parallel test runner.
Posted by Andrei Budnik <ab...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69612/#review212069
-----------------------------------------------------------
support/mesos-gtest-runner.py
Line 246 (original)
<https://reviews.apache.org/r/69612/#comment297680>
`EXECUTABLE` class variable is initialized with `abspath` and passed to `options_gen` as an argument.
I think it's the caller's duty to ensure that the path is absolute.
- Andrei Budnik
On Dec. 20, 2018, 4:40 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69612/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2018, 4:40 p.m.)
>
>
> Review request for mesos, Armand Grillet and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> support/mesos-gtest-runner.py 88a60c39e32730cd2875dc97c2d85cc314255050
>
>
> Diff: https://reviews.apache.org/r/69612/diff/1/
>
>
> Testing
> -------
>
> make check
> sudo make check
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 69612: Refactored parallel test runner.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69612/#review212080
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['69612']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2793/mesos-review-69612
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2793/mesos-review-69612/logs/mesos-tests.log):
```
I0116 21:02:42.454562 5428 master.cpp:1269] Agent d6b36ada-fe2d-4058-b3b7-038988d8af30-S0 at slave(468)@192.10.1.6:49906 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0116 21:02:42.455560 5428 master.cpp:3272] Disconnecting agent d6b36ada-fe2d-4058-b3b7-038988d8af30-S0 at slave(468)@192.10.1.6:49906 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0116 21:02:42.455560 5428 master.cpp:3291] Deactivating agent d6b36ada-fe2d-4058-b3b7-038988d8af30-S0 at slave(468)@192.10.1.6:49906 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0116 21:02:42.455560 3768 hierarchical.cpp:358] Removed framework d6b36ada-fe2d-4058-b3b7-038988d8af30-0000
I0116 21:02:42.455560 3768 hierarchical.cpp:802] Agent d6b36ada-fe2d-4058-b3b7-038988d8af30-S0 deactivated
I0116 21:02:42.456586 5428 containerizer.cpp:2469] Destroying container 7e8db58b-cec6-42c1-9192-ce74c3e89fb8 in RUNNING state
I0116 21:02:42.456586 5428 containerizer.cpp:3136] Transitioning the state of container 7e8db58b-cec6-42c1-9192-ce74c3e89fb8 from RUNNING to DESTROYING
I0116 21:02:42.457639 5428 launcher.cpp:161] Asked to destroy container 7e8db58b-cec6-42c1-9192-ce74c3e89fb8
W0116 21:02:42.458611 6388 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=2956 to peer '192.10.1.6:51750': IO failed with error code: The specified network name is no longer available.
W0116 21:02:42.458611 6388 p[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (589 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (607 ms total)
[----------] Global test environment tear-down
[==========] 1085 tests from 104 test cases ran. (499646 ms total)
[ PASSED ] 1083 tests.
[ FAILED ] 2 tests, listed below:
[ FAILED ] ContentType/MasterAPITest.OperationUpdatesUponAgentGone/0, where GetParam() = application/x-protobuf
[ FAILED ] ContentType/MasterAPITest.OperationUpdatesUponAgentGone/1, where GetParam() = application/json
2 FAILED TESTS
YOU HAVE 231 DISABLED TESTS
rocess.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=2296 to peer '192.10.1.6:51749': IO failed with error code: The specified network name is no longer available.
I0116 21:02:42.465565 6048 containerizer.cpp:2975] Container 7e8db58b-cec6-42c1-9192-ce74c3e89fb8 has exited
I0116 21:02:42.492586 7144 master.cpp:1109] Master terminating
I0116 21:02:42.494570 4228 hierarchical.cpp:644] Removed agent d6b36ada-fe2d-4058-b3b7-038988d8af30-S0
I0116 21:02:42.727299 6388 process.cpp:927] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Dec. 20, 2018, 8:40 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69612/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2018, 8:40 a.m.)
>
>
> Review request for mesos, Armand Grillet and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> support/mesos-gtest-runner.py 88a60c39e32730cd2875dc97c2d85cc314255050
>
>
> Diff: https://reviews.apache.org/r/69612/diff/2/
>
>
> Testing
> -------
>
> make check
> sudo make check
>
>
> Thanks,
>
> Andrei Budnik
>
>