You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/09/13 03:07:08 UTC

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #679: Remove volumeMounts when webhook is disabled

gxthrj commented on a change in pull request #679:
URL: https://github.com/apache/apisix-ingress-controller/pull/679#discussion_r706975140



##########
File path: test/e2e/scaffold/ingress.go
##########
@@ -276,10 +276,7 @@ spec:
             - --apisix-route-version
             - %s
             - --watch-endpointslices
-          volumeMounts:
-           - name: webhook-certs
-             mountPath: /etc/webhook/certs
-             readOnly: true
+          %s
       volumes:
        - name: webhook-certs

Review comment:
       Should this also be set  only when enableWebhook=true ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org